From: Federico Serafini <federico.serafini@bugseng.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: consulting@bugseng.com,
Simone Ballarin <simone.ballarin@bugseng.com>,
Doug Goldstein <cardoe@cardoe.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [XEN PATCH] automation/eclair: add deviation for MISRA C:2012 Rule 16.6
Date: Mon, 4 Mar 2024 09:19:42 +0100 [thread overview]
Message-ID: <fb415b35-a383-4327-a858-211ae3b7497f@bugseng.com> (raw)
In-Reply-To: <87326c7b-b7d8-4072-bced-d902e23134ed@suse.com>
On 04/03/24 09:04, Jan Beulich wrote:
> On 01.03.2024 16:04, Federico Serafini wrote:
>> --- a/docs/misra/deviations.rst
>> +++ b/docs/misra/deviations.rst
>> @@ -322,6 +322,12 @@ Deviations related to MISRA C:2012 Rules:
>> - /\* Fallthrough \*/
>> - /\* Fallthrough. \*/
>>
>> + * - R16.6
>> + - A switch statement with a single switch clause and no default label is
>> + deliberate and improves readability with respect to an equivalent if
>> + statement.
>> + - Tagged as `deliberate` for ECLAIR.
>
> Imo this is another example of wording a deviation in too wide a manner.
> It shouldn't be "is", but "may". Whether what is said here applies is
> entirely down to every specific instance; otherwise I'm inclined to read
> this as a suggestion to replace all if() by switch(), for that always
> improving readability. FTAOD things would be different if this was
> explanatory text to a SAF comment - there the specific context is always
> given (by where the comment actually appears).
Ok, I'll rephrase a v2.
--
Federico Serafini, M.Sc.
Software Engineer, BUGSENG (http://bugseng.com)
next prev parent reply other threads:[~2024-03-04 8:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 15:04 [XEN PATCH] automation/eclair: add deviation for MISRA C:2012 Rule 16.6 Federico Serafini
2024-03-02 0:47 ` Stefano Stabellini
2024-03-04 8:04 ` Jan Beulich
2024-03-04 8:19 ` Federico Serafini [this message]
2024-03-04 10:28 Federico Serafini
2024-03-04 10:32 ` Federico Serafini
2024-03-05 1:52 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb415b35-a383-4327-a858-211ae3b7497f@bugseng.com \
--to=federico.serafini@bugseng.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=consulting@bugseng.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=simone.ballarin@bugseng.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.