From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
stefanha@redhat.com, den@openvz.org
Subject: Re: [PATCH v3 for-5.1 0/2] Fix crash due to NBD export leak
Date: Fri, 17 Jul 2020 18:00:51 +0300 [thread overview]
Message-ID: <fb53ce2e-74a4-65c2-4347-878a88270591@virtuozzo.com> (raw)
In-Reply-To: <20200717120119.GC4550@linux.fritz.box>
17.07.2020 15:01, Kevin Wolf wrote:
> Am 14.07.2020 um 18:22 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> Hi all!
>>
>> We've faced crash bug, which is reproducing on master branch as well.
>> The case is described in 01, where fix is suggested.
>> New iotest in 02 crashes without that fix.
>>
>> v3: resend for convenience, as all preparatory patches are merged.
>> 01-02: add Eric's r-b and t-b marks
>>
>> ====
>>
>> This is a crash-fix, so it would be good to fix in 5.1. Still neither
>> Eric nor I are sure in patch 01: is AIO_WAIT_WHILE used correctly?
>
> Anything specific you had doubts about?
>
> At first sight it looks good to me. It's always called in the main loop
> and we don't hold any AioContext locks, so using NULL as the context is
> fine. You also made sure to use aio_wait_kick() so that we won't hang
> even though the condition has become false.
>
> I'm applying this to my block branch now. If your doubts were about
> something more subtle that I missed, we can unstage/revert the patch.
>
> Kevin
>
Nothing specific, thanks!
--
Best regards,
Vladimir
prev parent reply other threads:[~2020-07-17 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 16:22 [PATCH v3 for-5.1 0/2] Fix crash due to NBD export leak Vladimir Sementsov-Ogievskiy
2020-07-14 16:22 ` [PATCH v3 1/2] nbd: make nbd_export_close_all() synchronous Vladimir Sementsov-Ogievskiy
2020-07-14 16:22 ` [PATCH v3 2/2] iotests: test shutdown when bitmap is exported through NBD Vladimir Sementsov-Ogievskiy
2020-07-14 16:49 ` [PATCH v3 for-5.1 0/2] Fix crash due to NBD export leak no-reply
2020-07-14 16:59 ` Vladimir Sementsov-Ogievskiy
2020-07-14 17:26 ` Philippe Mathieu-Daudé
2020-07-17 12:01 ` Kevin Wolf
2020-07-17 15:00 ` Vladimir Sementsov-Ogievskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb53ce2e-74a4-65c2-4347-878a88270591@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.