Re: [PATCH 2/2] dt-bindings: trivial-devices: Add qca,spidev

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Paweł Owoc" <frut3k7@gmail.com>, "Rob Herring" <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Naresh Solanki <Naresh.Solanki@9elements.com>,
	Patrick Rudolph <patrick.rudolph@9elements.com>,
	Peter Yin <peteryin.openbmc@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Michal Simek <michal.simek@amd.com>,
	Lakshmi Yadlapati <lakshmiy@us.ibm.com>,
	Lukas Wunner <lukas@wunner.de>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	Fabio Estevam <festevam@denx.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: Add qca,spidev
Date: Tue, 6 Feb 2024 08:44:36 +0100	[thread overview]
Message-ID: <fb9767e0-c5a8-448f-b3f7-e6f81ef008e6@linaro.org> (raw)
In-Reply-To: <20240205191828.998783-1-frut3k7@gmail.com>

On 05/02/2024 20:18, Paweł Owoc wrote:
> Add Qualcomm QCA4024 to trivial devices.
> 
> Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 79dcd92c4a43..50efbdf2a735 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -309,6 +309,8 @@ properties:
>            - plx,pex8648
>              # Pulsedlight LIDAR range-finding sensor
>            - pulsedlight,lidar-lite-v2
> +            # Qualcomm QCA4024 Multi-mode Bluetooth and 802.15.4 SoC
> +          - qca,spidev

There is no such hardware as spidev and you even mentioned it is called
QCA4024, not spidev. Please don't use that name but a real name.

Also, I have doubts that Bluetooth is a trivial device. Such devices
need supplies, have reset/powerdown GPIOs.

Best regards,
Krzysztof