From: Daniel Borkmann <daniel@iogearbox.net>
To: Chris Down <chris@chrisdown.name>,
bpf@vger.kernel.org, netdev@vger.kernel.org
Cc: Stanislav Fomichev <sdf@google.com>,
Andrii Nakryiko <andriin@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2] bpf: btf: Always output invariant hit in pahole DWARF to BTF transform
Date: Wed, 22 Jan 2020 18:24:01 +0100 [thread overview]
Message-ID: <fcea8bd9-2bea-ddb2-449e-8640e772c487@iogearbox.net> (raw)
In-Reply-To: <20200122000110.GA310073@chrisdown.name>
On 1/22/20 1:01 AM, Chris Down wrote:
> When trying to compile with CONFIG_DEBUG_INFO_BTF enabled, I got this
> error:
>
> % make -s
> Failed to generate BTF for vmlinux
> Try to disable CONFIG_DEBUG_INFO_BTF
> make[3]: *** [vmlinux] Error 1
>
> Compiling again without -s shows the true error (that pahole is
> missing), but since this is fatal, we should show the error
> unconditionally on stderr as well, not silence it using the `info`
> function. With this patch:
>
> % make -s
> BTF: .tmp_vmlinux.btf: pahole (pahole) is not available
> Failed to generate BTF for vmlinux
> Try to disable CONFIG_DEBUG_INFO_BTF
> make[3]: *** [vmlinux] Error 1
>
> Signed-off-by: Chris Down <chris@chrisdown.name>
> Cc: Stanislav Fomichev <sdf@google.com>
> Cc: Andrii Nakryiko <andriin@fb.com>
> Cc: John Fastabend <john.fastabend@gmail.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: bpf@vger.kernel.org
> Cc: kernel-team@fb.com
Applied, thanks!
prev parent reply other threads:[~2020-01-22 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 0:01 [PATCH v2] bpf: btf: Always output invariant hit in pahole DWARF to BTF transform Chris Down
2020-01-22 0:05 ` Andrii Nakryiko
2020-01-22 17:24 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcea8bd9-2bea-ddb2-449e-8640e772c487@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.