From: Alexei Starovoitov <ast@fb.com>
To: Andrii Nakryiko <andriin@fb.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>
Cc: "andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH bpf-next] libbpf: fix off-by-one error in ELF sanity check
Date: Tue, 29 Oct 2019 03:29:00 +0000 [thread overview]
Message-ID: <fd09a18e-812a-4996-bfe0-6d8bb79de788@fb.com> (raw)
In-Reply-To: <20191028233727.1286699-1-andriin@fb.com>
On 10/28/19 4:37 PM, Andrii Nakryiko wrote:
> libbpf's bpf_object__elf_collect() does simple sanity check after iterating
> over all ELF sections, if checks that .strtab index is correct. Unfortunately,
> due to section indices being 1-based, the check breaks for cases when .strtab
> ends up being the very last section in ELF.
>
> Fixes: 77ba9a5b48a7 ("tools lib bpf: Fetch map names from correct strtab")
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
4 year old bug. Nice!
Applied. Thanks.
prev parent reply other threads:[~2019-10-29 3:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 23:37 [PATCH bpf-next] libbpf: fix off-by-one error in ELF sanity check Andrii Nakryiko
2019-10-29 3:29 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd09a18e-812a-4996-bfe0-6d8bb79de788@fb.com \
--to=ast@fb.com \
--cc=Kernel-team@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.