From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Ian Jackson" <iwj@xenproject.org>, "Wei Liu" <wl@xen.org>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Jürgen Groß" <jgross@suse.com>
Subject: Re: [PATCH 2/3] tools/libs: Stash the 4.14 API/ABIs for the stable libraries
Date: Tue, 2 Mar 2021 11:26:18 +0000 [thread overview]
Message-ID: <fd1eb50e-e68f-3648-5e2d-5653537c96ea@citrix.com> (raw)
In-Reply-To: <c06e2a00-6f23-5ddc-3404-572682a0bd51@suse.com>
On 02/03/2021 11:21, Jan Beulich wrote:
> On 02.03.2021 12:17, Andrew Cooper wrote:
>> On 02/03/2021 10:45, Jürgen Groß wrote:
>>> On 01.03.21 18:00, Andrew Cooper wrote:
>>>> These dumps were produced from the RELEASE-4.14.0 tag, with the
>>>> abi-dumper
>>>> tooling backported from staging.
>>>>
>>>> For each stable library, add a PKG_OLD_ABI variable pointing at the
>>>> 4.14 ABI.
>>>>
>>>> No functional change.
>>>>
>>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>>> ---
>>>> CC: Ian Jackson <iwj@xenproject.org>
>>>> CC: Wei Liu <wl@xen.org>
>>>> CC: Juergen Gross <jgross@suse.com>
>>>> ---
>>>> tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump | 924 +++++++++++
>>>> .../abi/libxendevicemodel.so.1.3-x86_64-abi.dump | 1491
>>>> +++++++++++++++++
>>>> tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump | 719 ++++++++
>>>> .../abi/libxenforeignmemory.so.1.3-x86_64-abi.dump | 847 ++++++++++
>>>> tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump | 1199
>>>> ++++++++++++++
>>>> tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump | 597 +++++++
>>>> .../libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump | 1711
>>>> ++++++++++++++++++++
>>>> .../libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump | 239 +++
>>>> .../libs/abi/libxentoollog.so.1.0-x86_64-abi.dump | 882 ++++++++++
>>>> tools/libs/call/Makefile | 2 +
>>>> tools/libs/devicemodel/Makefile | 2 +
>>>> tools/libs/evtchn/Makefile | 2 +
>>>> tools/libs/foreignmemory/Makefile | 2 +
>>>> tools/libs/gnttab/Makefile | 2 +
>>>> tools/libs/hypfs/Makefile | 2 +
>>>> tools/libs/store/Makefile | 2 +
>>>> tools/libs/toolcore/Makefile | 2 +
>>>> tools/libs/toollog/Makefile | 2 +
>>>> 18 files changed, 8627 insertions(+)
>>>> create mode 100644 tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump
>>>> create mode 100644
>>>> tools/libs/abi/libxendevicemodel.so.1.3-x86_64-abi.dump
>>>> create mode 100644 tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump
>>>> create mode 100644
>>>> tools/libs/abi/libxenforeignmemory.so.1.3-x86_64-abi.dump
>>>> create mode 100644 tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump
>>>> create mode 100644 tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump
>>>> create mode 100644 tools/libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump
>>>> create mode 100644
>>>> tools/libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump
>>>> create mode 100644 tools/libs/abi/libxentoollog.so.1.0-x86_64-abi.dump
>>>>
>>>> diff --git a/tools/libs/call/Makefile b/tools/libs/call/Makefile
>>>> index 4ed201b3b3..37a7db5395 100644
>>>> --- a/tools/libs/call/Makefile
>>>> +++ b/tools/libs/call/Makefile
>>>> @@ -11,4 +11,6 @@ SRCS-$(CONFIG_SunOS) += solaris.c
>>>> SRCS-$(CONFIG_NetBSD) += netbsd.c
>>>> SRCS-$(CONFIG_MiniOS) += minios.c
>>>> +PKG_OLD_ABI =
>>>> ../abi/libxen$(LIBNAME).so.1.2-$(XEN_TARGET_ARCH)-abi.dump
>>>> +
>>> Any reason you don't add
>>>
>>> PKG_OLD_ABI =
>>> ../abi/libxen$(LIBNAME).so.$(MAJOR).$(MINOR)-$(XEN_TARGET_ARCH)-abi.dump
>>>
>>> to tools/libs/libs.mk, maybe with some way to override/disable the
>>> setting (e.g. by setting a different value for PKG_OLD_ABI just
>>> after including $(XEN_ROOT)/tools/libs/libs.mk) ?
>> The problem is with libraries which have changed in staging, where
>> $MINOR differs by 1. I chose not to wildcard in ../abi/ to reduce the
>> chance of picking up the wrong ABI to check against.
>>
>> Something needs to be a statement of which is the appropriate $MINOR to
>> use, and it shouldn't be the change to bump the soname, as that is a
>> change we want to be tested.
> Introduce OLD_MINOR or ABI_OLD_MINOR?
That's not bisectable if it isn't in the changeset which bumps the soname.
~Andrew
next prev parent reply other threads:[~2021-03-02 11:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 17:00 [PATCH for-4.15 0/3] tools: ABI checking Andrew Cooper
2021-03-01 17:00 ` [PATCH 1/3] tools: Check for abi-compliance-checker in ./configure Andrew Cooper
2021-03-01 17:17 ` Ian Jackson
2021-03-01 17:00 ` [PATCH 2/3] tools/libs: Stash the 4.14 API/ABIs for the stable libraries Andrew Cooper
2021-03-01 17:18 ` Ian Jackson
2021-03-02 10:45 ` Jürgen Groß
2021-03-02 11:17 ` Andrew Cooper
2021-03-02 11:21 ` Jan Beulich
2021-03-02 11:26 ` Andrew Cooper [this message]
2021-03-02 11:38 ` Jan Beulich
2021-03-01 17:00 ` [PATCH 3/3] tools/libs: Check ABI # DO NOT APPLY YET Andrew Cooper
2021-03-01 17:30 ` [PATCH for-4.15 0/3] tools: ABI checking Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd1eb50e-e68f-3648-5e2d-5653537c96ea@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.