From: Guenter Roeck <linux@roeck-us.net>
To: Conor Dooley <conor@kernel.org>
Cc: Abdel Alkuor <alkuor@gmail.com>, Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Add AMS AS6200 temperature sensor
Date: Sun, 17 Dec 2023 16:57:10 -0800 [thread overview]
Message-ID: <fd337fdb-ca91-46f3-890a-2362a85580f9@roeck-us.net> (raw)
In-Reply-To: <20231217-disregard-buckshot-772429f0be34@spud>
On 12/17/23 13:44, Conor Dooley wrote:
> On Sun, Dec 17, 2023 at 01:39:37PM -0800, Guenter Roeck wrote:
>> On 12/17/23 12:58, Conor Dooley wrote:
>>> On Sat, Dec 16, 2023 at 11:39:29AM -0500, Abdel Alkuor wrote:
>>>> as6200 is a temperature sensor with a range between -40°C to
>>>> 125°C degrees and an accuracy of ±0.4°C degree between 0
>>>> and 65°C and ±1°C for the other ranges.
>>>>
>>>> Signed-off-by: Abdel Alkuor <alkuor@gmail.com>
>>>
>>> Is this not v3?
>>
>> FWIW, I don't recall seeing it.
>
> Ah, I think this was originally submitted to iio, went through 2
> iterations and then ended up here on Jonathan's advice.
>
Hmm, yes, that would have been a duplicate. If iio support for lm75
compatible sensors is needed for some reason, a hwmon -> iio bridge
would make more sense.
Thanks,
Guenter
>>
>>> Either way,
>>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>>>
>>
>> As I pointed out in my reply to the other patch, this chip is mostly
>> compatible to lm75 and almost register-compatible to tmp112, the only
>> difference being some configuration register bits.
>>
>> Bindings for this chip should be added to
>> Documentation/devicetree/bindings/hwmon/lm75.yaml.
>
> Ah. In that case, I would expect my tag not to be picked up by Abdel.
prev parent reply other threads:[~2023-12-18 0:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 16:39 [PATCH 1/2] dt-bindings: hwmon: Add AMS AS6200 temperature sensor Abdel Alkuor
2023-12-16 16:39 ` [PATCH 2/2] " Abdel Alkuor
2023-12-16 18:46 ` Guenter Roeck
2023-12-16 22:07 ` Abdel Alkuor
2023-12-17 1:40 ` Guenter Roeck
2023-12-17 4:59 ` Abdel Alkuor
2023-12-17 6:06 ` Guenter Roeck
2023-12-18 5:23 ` Abdel Alkuor
2023-12-17 11:49 ` kernel test robot
2023-12-18 0:31 ` kernel test robot
2023-12-17 20:58 ` [PATCH 1/2] dt-bindings: " Conor Dooley
2023-12-17 21:39 ` Guenter Roeck
2023-12-17 21:44 ` Conor Dooley
2023-12-18 0:57 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd337fdb-ca91-46f3-890a-2362a85580f9@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alkuor@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.