From: Moshe Shemesh <moshe@nvidia.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Moshe Shemesh" <moshe@mellanox.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Dean Luick <dean.luick@cornelisnetworks.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH v2 6/9] net/mlx5: Use RMW accessors for changing LNKCTL
Date: Wed, 17 May 2023 14:18:58 +0300 [thread overview]
Message-ID: <fdd518db-a759-b520-fb1e-d697d6f08682@nvidia.com> (raw)
In-Reply-To: <20230517105235.29176-7-ilpo.jarvinen@linux.intel.com>
On 5/17/2023 1:52 PM, Ilpo Järvinen wrote:
> Don't assume that only the driver would be accessing LNKCTL of the
> upstream bridge. ASPM policy changes can trigger write to LNKCTL
> outside of driver's control.
>
> Use RMW capability accessors which do proper locking to avoid losing
> concurrent updates to the register value.
>
> Fixes: eabe8e5e88f5 ("net/mlx5: Handle sync reset now event")
> Suggested-by: Lukas Wunner<lukas@wunner.de>
> Signed-off-by: Ilpo Järvinen<ilpo.jarvinen@linux.intel.com>
> Cc:stable@vger.kernel.org
Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
Thanks!
next prev parent reply other threads:[~2023-05-17 11:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 10:52 [PATCH v2 0/9] PCI: Improve PCIe Capability RMW concurrency control Ilpo Järvinen
2023-05-17 10:52 ` [PATCH v2 1/9] PCI: Add locking to RMW PCI Express Capability Register accessors Ilpo Järvinen
2023-05-17 11:32 ` Rafael J. Wysocki
2023-05-17 10:52 ` [PATCH v2 2/9] PCI: pciehp: Use RMW accessors for changing LNKCTL Ilpo Järvinen
2023-05-17 11:32 ` Rafael J. Wysocki
2023-05-17 10:52 ` [PATCH v2 3/9] PCI/ASPM: " Ilpo Järvinen
2023-05-17 11:33 ` Rafael J. Wysocki
2023-06-16 19:10 ` Lukas Wunner
2023-06-19 14:45 ` Ilpo Järvinen
2023-06-19 15:09 ` Bjorn Helgaas
2023-06-19 16:06 ` Ilpo Järvinen
2023-05-17 10:52 ` [PATCH v2 4/9] drm/amdgpu: " Ilpo Järvinen
2023-05-17 10:52 ` Ilpo Järvinen
2023-05-17 10:52 ` [PATCH v2 5/9] drm/radeon: " Ilpo Järvinen
2023-05-17 10:52 ` Ilpo Järvinen
2023-05-17 10:52 ` [PATCH v2 6/9] net/mlx5: " Ilpo Järvinen
2023-05-17 11:18 ` Moshe Shemesh [this message]
2023-05-17 10:52 ` [PATCH v2 7/9] wifi: ath11k: " Ilpo Järvinen
2023-05-17 10:52 ` Ilpo Järvinen
2023-05-17 11:04 ` Kalle Valo
2023-05-17 11:04 ` Kalle Valo
2023-05-17 10:52 ` [PATCH v2 8/9] wifi: ath12k: " Ilpo Järvinen
2023-05-17 10:52 ` Ilpo Järvinen
2023-05-17 11:03 ` Kalle Valo
2023-05-17 11:03 ` Kalle Valo
2023-05-17 10:52 ` [PATCH v2 9/9] wifi: ath10k: " Ilpo Järvinen
2023-05-17 10:52 ` Ilpo Järvinen
2023-05-17 11:05 ` Kalle Valo
2023-05-17 11:05 ` Kalle Valo
2023-05-24 15:10 ` Bjorn Helgaas
2023-05-24 15:10 ` Bjorn Helgaas
2023-05-25 10:11 ` Ilpo Järvinen
2023-05-25 10:11 ` Ilpo Järvinen
2023-05-26 11:48 ` Ilpo Järvinen
2023-05-26 11:48 ` Ilpo Järvinen
2023-05-26 22:26 ` Bjorn Helgaas
2023-05-26 22:26 ` Bjorn Helgaas
2023-05-26 22:20 ` Bjorn Helgaas
2023-05-26 22:20 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdd518db-a759-b520-fb1e-d697d6f08682@nvidia.com \
--to=moshe@nvidia.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=dean.luick@cornelisnetworks.com \
--cc=edumazet@google.com \
--cc=emmanuel.grumbach@intel.com \
--cc=hkallweit1@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kuba@kernel.org \
--cc=kw@linux.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lukas@wunner.de \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=saeedm@nvidia.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.