From: Richard Henderson <richard.henderson@linaro.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Cc: laurent@vivier.eu, Xiaojuan Yang <yangxiaojuan@loongson.cn>
Subject: Re: [PATCH v19 02/13] linux-user: Add LoongArch signal support
Date: Thu, 23 Jun 2022 16:34:11 -0700 [thread overview]
Message-ID: <fe3d36d7-2ad1-94d1-dd06-e650916b37fd@linaro.org> (raw)
In-Reply-To: <20220623085526.1678168-3-gaosong@loongson.cn>
On 6/23/22 01:55, Song Gao wrote:
> +static void setup_sigcontext(CPULoongArchState *env,
> + struct target_sigcontext *sc,
> + struct extctx_layout *extctx)
> +{
> + int i;
> +
> + if (extctx->flags & SC_USED_FP) {
> + __put_user(extctx->fpu.addr, &sc->sc_extcontext[0]);
> + } else {
> + __put_user(extctx->end.addr, &sc->sc_extcontext[0]);
> + }
This is incorrect. Where did this come from? It certainly doesn't appear in the kernel's
version of setup_sigcontext. The only reason the result works for you is that this is
overwritten by copy_fpu_to_sigframe within setup_sigframe.
r~
next prev parent reply other threads:[~2022-06-23 23:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 8:55 [PATCH v19 00/13] Add LoongArch linux-user emulation support Song Gao
2022-06-23 8:55 ` [PATCH v19 01/13] linux-user: Add LoongArch generic header files Song Gao
2022-06-23 8:55 ` [PATCH v19 02/13] linux-user: Add LoongArch signal support Song Gao
2022-06-23 23:34 ` Richard Henderson [this message]
2022-06-24 0:45 ` maobibo
2022-06-24 1:13 ` maobibo
2022-06-24 1:20 ` Richard Henderson
2022-06-24 1:41 ` gaosong
2022-06-23 8:55 ` [PATCH v19 03/13] linux-user: Add LoongArch elf support Song Gao
2022-06-23 8:55 ` [PATCH v19 04/13] linux-user: Add LoongArch syscall support Song Gao
2022-06-23 8:55 ` [PATCH v19 05/13] linux-user: Add LoongArch cpu_loop support Song Gao
2022-06-23 8:55 ` [PATCH v19 06/13] scripts: add loongarch64 binfmt config Song Gao
2022-06-23 8:55 ` [PATCH v19 07/13] target/loongarch: remove badaddr from CPULoongArch Song Gao
2022-06-23 8:55 ` [PATCH v19 08/13] target/loongarch: Fix missing update CSR_BADV Song Gao
2022-06-23 8:55 ` [PATCH v19 09/13] target/loongarch: Fix helper_asrtle_d/asrtgt_d raise wrong exception Song Gao
2022-06-23 8:55 ` [PATCH v19 10/13] target/loongarch: remove unused include hw/loader.h Song Gao
2022-06-23 8:55 ` [PATCH v19 11/13] target/loongarch: Adjust functions and structure to support user-mode Song Gao
2022-06-23 8:55 ` [PATCH v19 12/13] default-configs: Add loongarch linux-user support Song Gao
2022-06-23 8:55 ` [PATCH v19 13/13] target/loongarch: Update README Song Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe3d36d7-2ad1-94d1-dd06-e650916b37fd@linaro.org \
--to=richard.henderson@linaro.org \
--cc=gaosong@loongson.cn \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.