From: Richard Henderson <richard.henderson@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>, qemu-devel@nongnu.org
Cc: f4bug@amsat.org, ale@rev.ng, anjo@rev.ng, bcain@quicinc.com,
mlambert@quicinc.com
Subject: Re: [PATCH 2/3] Hexagon (tests/tcg/hexagon) Fix alignment in load_unpack.c
Date: Fri, 29 Jul 2022 10:08:08 -0700 [thread overview]
Message-ID: <ff4525a2-f115-27d5-9615-e7a78bd9d346@linaro.org> (raw)
In-Reply-To: <20220718230320.24444-3-tsimpson@quicinc.com>
On 7/18/22 16:03, Taylor Simpson wrote:
> The increment used in :brev tests was causing unaligned addresses
> Change the increment and the relevant expected values
>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
> tests/tcg/hexagon/load_unpack.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Acked-by: Richard Henderson <richard.henderson@linaro.org>
r~
>
> diff --git a/tests/tcg/hexagon/load_unpack.c b/tests/tcg/hexagon/load_unpack.c
> index 3575a37a28..4aa26fc388 100644
> --- a/tests/tcg/hexagon/load_unpack.c
> +++ b/tests/tcg/hexagon/load_unpack.c
> @@ -245,7 +245,7 @@ TEST_pr(loadbsw4_pr, long long, S, 4, 0x0000ff000000ff00LL,
> */
> #define BxW_LOAD_pbr(SZ, RES, PTR) \
> __asm__( \
> - "r4 = #(1 << (16 - 3))\n\t" \
> + "r4 = #(1 << (16 - 4))\n\t" \
> "m0 = r4\n\t" \
> "%0 = mem" #SZ "(%1++m0:brev)\n\t" \
> : "=r"(RES), "+r"(PTR) \
> @@ -273,15 +273,15 @@ void test_##NAME(void) \
> }
>
> TEST_pbr(loadbzw2_pbr, int, Z, 0x00000000,
> - 0x00020081, 0x00060085, 0x00040083, 0x00080087)
> + 0x00020081, 0x000a0089, 0x00060085, 0x000e008d)
> TEST_pbr(loadbsw2_pbr, int, S, 0x0000ff00,
> - 0x00020081, 0x00060085, 0x00040083, 0x00080087)
> + 0x00020081, 0x000aff89, 0x0006ff85, 0x000eff8d)
> TEST_pbr(loadbzw4_pbr, long long, Z, 0x0000000000000000LL,
> - 0x0004008300020081LL, 0x0008008700060085LL,
> - 0x0006008500040083LL, 0x000a008900080087LL)
> + 0x0004008300020081LL, 0x000c008b000a0089LL,
> + 0x0008008700060085LL, 0x0010008f000e008dLL)
> TEST_pbr(loadbsw4_pbr, long long, S, 0x0000ff000000ff00LL,
> - 0x0004008300020081LL, 0x0008008700060085LL,
> - 0x0006008500040083LL, 0x000a008900080087LL)
> + 0x0004008300020081LL, 0x000cff8b000aff89LL,
> + 0x0008ff870006ff85LL, 0x0010ff8f000eff8dLL)
>
> /*
> ****************************************************************************
next prev parent reply other threads:[~2022-07-29 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 23:03 [PATCH 0/3] Hexagon bug fixes and test improvements Taylor Simpson
2022-07-18 23:03 ` [PATCH 1/3] Hexagon (target/hexagon) make VyV operands use a unique temp Taylor Simpson
2022-07-29 17:06 ` Richard Henderson
2022-07-18 23:03 ` [PATCH 2/3] Hexagon (tests/tcg/hexagon) Fix alignment in load_unpack.c Taylor Simpson
2022-07-29 17:08 ` Richard Henderson [this message]
2022-07-18 23:03 ` [PATCH 3/3] Hexagon (tests/tcg/hexagon) reference file for float_convd Taylor Simpson
2022-07-29 17:08 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff4525a2-f115-27d5-9615-e7a78bd9d346@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=f4bug@amsat.org \
--cc=mlambert@quicinc.com \
--cc=qemu-devel@nongnu.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.