From: Dave Hansen <dave.hansen@intel.com>
To: Marc Orr <marcorr@google.com>,
kvm@vger.kernel.org, jmattson@google.com, rientjes@google.com,
konrad.wilk@oracle.com, linux-mm@kvack.org,
akpm@linux-foundation.org, pbonzini@redhat.com,
rkrcmar@redhat.com, willy@infradead.org,
sean.j.christopherson@intel.com, dave.hansen@linux.intel.com,
kernellwp@gmail.com
Subject: Re: [kvm PATCH v7 2/2] kvm: x86: Dynamically allocate guest_fpu
Date: Tue, 6 Nov 2018 14:49:52 -0800 [thread overview]
Message-ID: <ff90f374-caea-9530-0c90-b27d00efacc1@intel.com> (raw)
In-Reply-To: <20181106222009.90833-3-marcorr@google.com>
On 11/6/18 2:20 PM, Marc Orr wrote:
> r = -ENOMEM;
> + x86_fpu_cache = kmem_cache_create_usercopy(
> + "x86_fpu",
> + fpu_kernel_xstate_size,
> + __alignof__(struct fpu),
> + SLAB_ACCOUNT,
> + offsetof(struct fpu, state),
> + fpu_kernel_xstate_size,
> + NULL);
I thought we came to the conclusion with Paulo that this should not be
"usercopy" at all.
Did you send out an old version?
next prev parent reply other threads:[~2018-11-06 22:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 22:20 [kvm PATCH v7 0/2] shrink vcpu_vmx down to order 2 Marc Orr
2018-11-06 22:20 ` [kvm PATCH v7 1/2] kvm: x86: Use task structs fpu field for user Marc Orr
2018-11-06 22:20 ` [kvm PATCH v7 2/2] kvm: x86: Dynamically allocate guest_fpu Marc Orr
2018-11-06 22:49 ` Dave Hansen [this message]
2018-11-06 22:51 ` Marc Orr
2018-12-21 10:28 ` Paolo Bonzini
2018-12-21 17:30 ` Marc Orr
2018-12-21 17:30 ` Marc Orr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff90f374-caea-9530-0c90-b27d00efacc1@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=jmattson@google.com \
--cc=kernellwp@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcorr@google.com \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.