From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Niklas Cassel <Niklas.Cassel@wdc.com>
Subject: [PATCH v2 1/4] zbd: only put an upper limit on max open zones once
Date: Fri, 14 May 2021 12:52:51 +0000 [thread overview]
Message-ID: <20210514125233.10508-2-Niklas.Cassel@wdc.com> (raw)
In-Reply-To: <20210514125233.10508-1-Niklas.Cassel@wdc.com>
From: Niklas Cassel <niklas.cassel@wdc.com>
There is an upper limit that is checked for each td, and for each file,
even though a file has a pointer to a zoned_block_device_info that has
already been created. Multiple files, from the same or from another td
can point to the same zoned_block_device_info.
All zoned_block_device_info:s have already been created earlier in the
call chain.
Simplify this by only checking the upper limit on max open zones when a
zoned_block_device_info is created.
This way, max_open_zones is handled from a single location, instead of
potentially being reassigned from a completely different location.
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
---
zbd.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/zbd.c b/zbd.c
index eed796b3..46ff9aeb 100644
--- a/zbd.c
+++ b/zbd.c
@@ -588,7 +588,8 @@ static int zbd_create_zone_info(struct thread_data *td, struct fio_file *f)
if (ret == 0) {
f->zbd_info->model = zbd_model;
- f->zbd_info->max_open_zones = td->o.max_open_zones;
+ f->zbd_info->max_open_zones =
+ min_not_zero(td->o.max_open_zones, ZBD_MAX_OPEN_ZONES);
}
return ret;
}
@@ -726,8 +727,6 @@ int zbd_setup_files(struct thread_data *td)
if (zbd_is_seq_job(f))
assert(f->min_zone < f->max_zone);
- zbd->max_open_zones = zbd->max_open_zones ?: ZBD_MAX_OPEN_ZONES;
-
if (td->o.max_open_zones > 0 &&
zbd->max_open_zones != td->o.max_open_zones) {
log_err("Different 'max_open_zones' values\n");
--
2.25.1
next prev parent reply other threads:[~2021-05-14 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 12:52 [PATCH v2 0/4] Improve fio max open zones handling Niklas Cassel
2021-05-14 12:52 ` Niklas Cassel [this message]
2021-05-14 12:52 ` [PATCH v2 2/4] oslib/linux-blkzoned: move sysfs reading into its own function Niklas Cassel
2021-05-14 12:53 ` [PATCH v2 3/4] ioengines: add get_max_open_zones zoned block device operation Niklas Cassel
2021-05-14 12:53 ` [PATCH v2 4/4] engines/libzbc: add support for the get_max_open_zones io op Niklas Cassel
2021-05-14 14:57 ` [PATCH v2 0/4] Improve fio max open zones handling Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210514125233.10508-2-Niklas.Cassel@wdc.com \
--to=niklas.cassel@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).