From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
"adobriyan@gmail.com" <adobriyan@gmail.com>,
Niklas Cassel <Niklas.Cassel@wdc.com>
Subject: [PATCH 0/3] fix max open zones handling when using multiple jobs
Date: Thu, 24 Jun 2021 17:23:06 +0000 [thread overview]
Message-ID: <20210624172256.37177-1-Niklas.Cassel@wdc.com> (raw)
From: Niklas Cassel <niklas.cassel@wdc.com>
Currently, the fio handling of max open zones is very fragile.
zbd_open_zone() uses zbd_info->max_open_zones when checking
the max open zones limit, while zbd_convert_to_open_zone()
uses td->o.max_open_zones when performing the same limit check.
It is simply wrong to use td->o.max_open_zones after zbd_setup_files().
Change zbd_convert_to_open_zone() to use zbd_info->max_open_zones.
This way, the global max open zones limit (which is per device) will be
respected for all jobs.
This series also adds a patch that reintroduces the ability to
run write workloads with no limit on the maximum number of open zones.
In this case, tracking of open zones in the zbd_info->open_zones array
is disabled to reduce overhead.
Niklas Cassel (3):
zbd: create a local zbdi variable for f->zbd_info
zbd: allow an unlimited global max open zones limit
zbd: ensure that global max open zones limit is respected
zbd.c | 111 +++++++++++++++++++++++++++++++++++++---------------------
zbd.h | 3 +-
2 files changed, 73 insertions(+), 41 deletions(-)
--
2.25.1
next reply other threads:[~2021-06-24 17:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 17:23 Niklas Cassel [this message]
2021-06-24 17:23 ` [PATCH 1/3] zbd: create a local zbdi variable for f->zbd_info Niklas Cassel
2021-06-24 20:09 ` Alexey Dobriyan
2021-06-28 10:42 ` Niklas Cassel
2021-06-25 7:07 ` Damien Le Moal
2021-06-24 17:23 ` [PATCH 2/3] zbd: allow an unlimited global max open zones limit Niklas Cassel
2021-06-25 7:09 ` Damien Le Moal
2021-06-24 17:23 ` [PATCH 3/3] zbd: ensure that global max open zones limit is respected Niklas Cassel
2021-06-25 7:11 ` Damien Le Moal
2021-06-25 7:48 ` Shinichiro Kawasaki
2021-06-29 13:44 ` [PATCH 0/3] fix max open zones handling when using multiple jobs Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624172256.37177-1-Niklas.Cassel@wdc.com \
--to=niklas.cassel@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=adobriyan@gmail.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).