From: "Friendy.Su@sony.com" <Friendy.Su@sony.com>
To: Vincent Fu <vincentfu@gmail.com>, fio <fio@vger.kernel.org>
Cc: "Wataru.Aoyama@sony.com" <Wataru.Aoyama@sony.com>
Subject: RE: [PATCH] engines: add engine for directory create
Date: Mon, 1 Aug 2022 06:58:55 +0000 [thread overview]
Message-ID: <HK0PR04MB23888F561D44A542D9E6115AFD9A9@HK0PR04MB2388.apcprd04.prod.outlook.com> (raw)
In-Reply-To: <79535fa5-66c4-d7df-73f8-a128e9b4150b@gmail.com>
Thanks for comment.
I merged filecreate, filestat, filedelelete engines to fileoperations.c. The patch has been issued in another thread.
-----Original Message-----
From: Vincent Fu <vincentfu@gmail.com>
Sent: Monday, July 18, 2022 7:24 PM
To: Su, Friendy <Friendy.Su@sony.com>; fio <fio@vger.kernel.org>
Cc: Aoyama, Wataru (SGC) <Wataru.Aoyama@sony.com>
Subject: Re: [PATCH] engines: add engine for directory create
On 6/11/22 03:34, Friendy.Su@sony.com wrote:
>
> This engine is to measure performance of creating directories.
>
> Signed-off-by: friendy-su <friendy.su@sony.com>
This all seems fine. My main suggestion is that there seem to be several
of these file operation ioengines. It seems like we could eliminate
duplicated code and make the codebase easier to maintain by
consolidating the ioengines (filedelete, filestat, etc) that follow this
similar structure.
sync.c is an example that implements several ioengines.
prev parent reply other threads:[~2022-08-01 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 7:34 [PATCH] engines: add engine for directory create Friendy.Su
2022-07-18 11:24 ` Vincent Fu
2022-08-01 6:58 ` Friendy.Su [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HK0PR04MB23888F561D44A542D9E6115AFD9A9@HK0PR04MB2388.apcprd04.prod.outlook.com \
--to=friendy.su@sony.com \
--cc=Wataru.Aoyama@sony.com \
--cc=fio@vger.kernel.org \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).