From: Jens Axboe <axboe@kernel.dk>
To: Stefan Hajnoczi <stefanha@redhat.com>, fio@vger.kernel.org
Cc: Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH] Makefile: use override directive on engine CFLAGS
Date: Wed, 7 Jul 2021 07:06:27 -0600 [thread overview]
Message-ID: <dc2b5428-3af3-db12-b9a0-529f8bac0b87@kernel.dk> (raw)
In-Reply-To: <20210706172700.189584-1-stefanha@redhat.com>
On 7/6/21 11:27 AM, Stefan Hajnoczi wrote:
> The GNU Make documentation says the following about the override
> keyword:
>
> Subsequent assignments or appends to this variable which are not
> marked override will be ignored.
>
> https://www.gnu.org/software/make/manual/html_node/Override-Directive.html
>
> When the override CFLAGS line was moved in commit
> f4bd2c3d80bc35f76892205a7e50426711e3def3 it broke the engine template,
> which does not use the override directive. Since the engine template is
> now evaluated afterwards, the engine CFLAGS are ignored.
>
> Add the override keyword to the engine template so that engine CFLAGS
> are honored again.
>
> Note that the CONFIG_DYNAMIC_ENGINES case doesn't need the override
> directive. It seems that GNU Make assigns CFLAGS even without the
> override directive in this case:
>
> $$($(1)_OBJS): CFLAGS := -fPIC $$($(1)_CFLAGS) $(CFLAGS)
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-07-07 13:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 17:27 [PATCH] Makefile: use override directive on engine CFLAGS Stefan Hajnoczi
2021-07-07 13:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc2b5428-3af3-db12-b9a0-529f8bac0b87@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).