All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Seibold <mail@bernhard-seibold.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Jiri Kosina <jikos@kernel.org>,
	 Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Hans de Goede <hdegoede@redhat.com>,
	 Jamie Lentin <jm@lentin.co.uk>
Subject: Re: Re: [PATCH 1/3] HID: input - Add microphone mute LED support
Date: Thu, 4 Jan 2024 19:46:32 +0100	[thread overview]
Message-ID: <fm6z2zok4ndbke3zqvrm7zbmkukul65n5unl5xkgmlccswz3hl@ycpnx2ii5wu4> (raw)
In-Reply-To: <ZZbxHpibdyNY_zUt@google.com>

Hi Dmitri,

On Thu, Jan 04, 2024 at 09:55:42AM -0800, Dmitry Torokhov wrote:
> No, please do not add new LEDs to input subsystem, and instead use "new"
> LED APIs that are much more flexible. That is why we built the input
> leds bridge in direction of input->leds and on the other way around.
> 
> The existing input LED definitions are grandfathered because they are
> exposed to userspace (via evdev), but we will not be adding new ones.
> 
> Thanks.

Sorry, I'm completely new to this subsystem. Did I get it right that
what you're suggesting is to add something that is similar to
hidinput_setup_battery() and create the new LED there directly,
skipping the input subsystem and input-leds completely?

Regards,
Bernhard

  reply	other threads:[~2024-01-04 18:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04 15:49 [PATCH 1/3] HID: input - Add microphone mute LED support Bernhard Seibold
2024-01-04 15:49 ` [PATCH 2/3] Input: leds - add micmute and triggers Bernhard Seibold
2024-01-04 15:49 ` [PATCH 3/3] HID: lenovo: Remove LEDs from tpkbd Bernhard Seibold
2024-01-04 17:55 ` [PATCH 1/3] HID: input - Add microphone mute LED support Dmitry Torokhov
2024-01-04 18:46   ` Bernhard Seibold [this message]
2024-01-04 18:56     ` Dmitry Torokhov
2024-01-13 10:37   ` [PATCH v2 1/2] Input: leds - set default-trigger for mute Bernhard Seibold
2024-01-13 10:37     ` [PATCH v2 2/2] HID: input: add support for micmute LED Bernhard Seibold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fm6z2zok4ndbke3zqvrm7zbmkukul65n5unl5xkgmlccswz3hl@ycpnx2ii5wu4 \
    --to=mail@bernhard-seibold.de \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=jikos@kernel.org \
    --cc=jm@lentin.co.uk \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.