From: Pavel Reichl <preichl@redhat.com>
To: Zorro Lang <zlang@redhat.com>
Cc: Eryu Guan <guan@eryu.me>, fstests@vger.kernel.org
Subject: Re: [PATCH v2 1/4] common/rc: Add _require_{chown,chmod,symlink}()
Date: Wed, 31 Mar 2021 09:17:16 +0200 [thread overview]
Message-ID: <00b3414f-4833-f0f3-22de-984ad359a57c@redhat.com> (raw)
In-Reply-To: <20210331002521.GP13946@localhost.localdomain>
On 3/31/21 2:25 AM, Zorro Lang wrote:
> On Wed, Mar 31, 2021 at 12:00:02AM +0200, Pavel Reichl wrote:
>> Add helper functions that ensure that test is only executed on file
>> systems that implement chown, chmod and symbolic links.
>>
>> +
>> +# check for a symbolic links support
>> +#
>> +_require_symlink()
>> +{
>> + if [ "$FSTYP" = "exfat" ]; then
>> + _notrun "symbolic links are not supported on $FSTYP"
>> + fi
>> +}
>
> There's _require_symlinks() in common/rc, I remember Eric used it for some
> exfat errors before. Does it work for you?
>
Hi,
Thanks for the info! Yes, it works. I will fix it in the next version.
I'll just wait for more comments a few days...I guess.
Thanks!
Bye.
next prev parent reply other threads:[~2021-03-31 7:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 22:00 [PATCH v2 0/4] Fix some tests that fail for exfat FS Pavel Reichl
2021-03-30 22:00 ` [PATCH v2 1/4] common/rc: Add _require_{chown,chmod,symlink}() Pavel Reichl
2021-03-31 0:25 ` Zorro Lang
2021-03-31 7:17 ` Pavel Reichl [this message]
2021-04-01 3:38 ` Eryu Guan
2021-04-01 9:47 ` Pavel Reichl
2021-04-07 16:47 ` Eric Sandeen
2021-03-30 22:00 ` [PATCH v2 2/4] common: hide permision warning from mkswap for exfat Pavel Reichl
2021-04-07 17:03 ` Eric Sandeen
2021-04-15 9:15 ` Pavel Reichl
2021-03-30 22:00 ` [PATCH v2 3/4] generic/554: hide permision warning on exfat Pavel Reichl
2021-04-01 3:40 ` Eryu Guan
2021-03-30 22:00 ` [PATCH v2 4/4] generic/003: Amend the test for exfat Pavel Reichl
2021-04-07 18:03 ` Eric Sandeen
2021-04-15 9:14 ` Pavel Reichl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00b3414f-4833-f0f3-22de-984ad359a57c@redhat.com \
--to=preichl@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).