From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>,
Eryu Guan <guaneryu@gmail.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] xfs: test that reflink forces the log if mounted with wsync
Date: Wed, 29 Jul 2020 11:02:09 +0800 [thread overview]
Message-ID: <0fd7ab73-9b6b-7e71-c50a-c829aaa89326@cn.fujitsu.com> (raw)
In-Reply-To: <20200729025203.GX7600@magnolia>
Hi Darrick
I remember this case has been merged into xfstests.
See
https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?id=06fd8dbbfe314410a2f55168f92e98ab93666013
Best Regards
Yang Xu
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> A code inspection revealed that reflink does not force the log to disk
> even if the filesystem is mounted with wsync. Add a regression test for
> commit 5833112df7e9a ("xfs: reflink should force the log out if mounted
> with wsync").
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/xfs/914 | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> tests/xfs/914.out | 7 ++++++
> tests/xfs/group | 1 +
> 3 files changed, 73 insertions(+)
> create mode 100755 tests/xfs/914
> create mode 100644 tests/xfs/914.out
>
> diff --git a/tests/xfs/914 b/tests/xfs/914
> new file mode 100755
> index 00000000..b835394a
> --- /dev/null
> +++ b/tests/xfs/914
> @@ -0,0 +1,65 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +# Copyright (c) 2020, Oracle and/or its affiliates. All Rights Reserved.
> +#
> +# FS QA Test No. 914
> +#
> +# Make sure that reflink forces the log out if we mount with wsync. We test
> +# that it actually forced the log by immediately shutting down the fs without
> +# flushing the log and then remounting to check file contents.
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +. ./common/reflink
> +
> +# real QA test starts here
> +_supported_fs xfs
> +_supported_os Linux
> +_require_scratch_reflink
> +_require_cp_reflink
> +
> +rm -f $seqres.full
> +
> +# Format filesystem and set up quota limits
> +_scratch_mkfs > $seqres.full
> +_scratch_mount -o wsync >> $seqres.full
> +
> +# Set up initial files
> +$XFS_IO_PROG -f -c 'pwrite -S 0x58 0 1m -b 1m' $SCRATCH_MNT/a >> $seqres.full
> +$XFS_IO_PROG -f -c 'pwrite -S 0x59 0 1m -b 1m' $SCRATCH_MNT/c >> $seqres.full
> +_cp_reflink $SCRATCH_MNT/a $SCRATCH_MNT/e
> +_cp_reflink $SCRATCH_MNT/c $SCRATCH_MNT/d
> +touch $SCRATCH_MNT/b
> +sync
> +
> +# Test that setting the reflink flag on the dest file forces the log
> +echo "test reflink flag not set"
> +$XFS_IO_PROG -x -c "reflink $SCRATCH_MNT/a" -c 'shutdown' $SCRATCH_MNT/b >> $seqres.full
> +_scratch_cycle_mount wsync
> +md5sum $SCRATCH_MNT/a $SCRATCH_MNT/b | _filter_scratch
> +
> +# Test forcing the log even if both files are already reflinked
> +echo "test reflink flag already set"
> +$XFS_IO_PROG -x -c "reflink $SCRATCH_MNT/a" -c 'shutdown' $SCRATCH_MNT/d >> $seqres.full
> +_scratch_cycle_mount wsync
> +md5sum $SCRATCH_MNT/a $SCRATCH_MNT/d | _filter_scratch
> +
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/xfs/914.out b/tests/xfs/914.out
> new file mode 100644
> index 00000000..6b19fc65
> --- /dev/null
> +++ b/tests/xfs/914.out
> @@ -0,0 +1,7 @@
> +QA output created by 914
> +test reflink flag not set
> +310f146ce52077fcd3308dcbe7632bb2 SCRATCH_MNT/a
> +310f146ce52077fcd3308dcbe7632bb2 SCRATCH_MNT/b
> +test reflink flag already set
> +310f146ce52077fcd3308dcbe7632bb2 SCRATCH_MNT/a
> +310f146ce52077fcd3308dcbe7632bb2 SCRATCH_MNT/d
> diff --git a/tests/xfs/group b/tests/xfs/group
> index d6e8d1c3..a3d87124 100644
> --- a/tests/xfs/group
> +++ b/tests/xfs/group
> @@ -518,3 +518,4 @@
> 518 auto quick quota
> 519 auto quick reflink
> 520 auto quick reflink
> +914 auto quick reflink
>
>
next prev parent reply other threads:[~2020-07-29 3:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 2:52 [PATCH] xfs: test that reflink forces the log if mounted with wsync Darrick J. Wong
2020-07-29 3:02 ` Yang Xu [this message]
2020-07-29 3:21 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fd7ab73-9b6b-7e71-c50a-c829aaa89326@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).