From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: <fstests@vger.kernel.org>
Cc: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Subject: [PATCH] xfs/097: Remove wrong broken assignment operation
Date: Mon, 7 Oct 2019 15:15:15 +0800 [thread overview]
Message-ID: <1570432515-13184-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> (raw)
On old kernel, since commit ded188b8609 ("xfs: Fix the situation that mount
operation rejects corrupted XFS") running this case got the mismatched output,
as below:
-----------------------------------
+ check fs
+ corrupt image
+ mount image && modify files
-broken: 1
+broken: 0
+ repair fs
+ mount image (2)
------------------------------------
It fails because the broken is always equal to 0 when _try_scratch_mount
succeed. So remove this wrong assignment operation.
Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
tests/xfs/097 | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/xfs/097 b/tests/xfs/097
index 1cb7d69c..20791738 100755
--- a/tests/xfs/097
+++ b/tests/xfs/097
@@ -81,8 +81,6 @@ done
echo "+ mount image && modify files"
broken=1
if _try_scratch_mount >> $seqres.full 2>&1; then
-
- broken=0
for x in `seq 65 70`; do
touch "${TESTFILE}.${x}" 2> /dev/null && broken=0
done
--
2.18.1
next reply other threads:[~2019-10-07 7:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 7:15 Yang Xu [this message]
2019-10-07 15:12 ` [PATCH] xfs/097: Remove wrong broken assignment operation Darrick J. Wong
2019-10-08 2:39 ` Yang Xu
2019-10-14 16:39 ` Darrick J. Wong
2019-10-15 6:27 ` Yang Xu
2019-10-21 12:09 ` Yang Xu
2019-10-21 15:50 ` Darrick J. Wong
2019-10-22 1:49 ` Yang Xu
2019-10-22 1:55 ` Darrick J. Wong
2019-10-22 2:06 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1570432515-13184-1-git-send-email-xuyang2018.jy@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).