From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: <fstests@vger.kernel.org>
Cc: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Subject: [PATCH] generic/520: use fsync instead of sync during clean_dir
Date: Fri, 13 Dec 2019 13:45:41 +0800 [thread overview]
Message-ID: <1576215941-19208-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> (raw)
When I test this case on xfs, it may fail as below:
--------------------------------------------
=== link SCRATCH_MNT/A/foo SCRATCH_MNT/bar with fsync SCRATCH_MNT/A ===
+umount: /mnt/xfstests/scratch: target is busy.
+ (In some cases useful info about processes that use
+ the device is found by lsof(8) or fuser(1))
---------------------------------------------
I think we don't need to sync all fs and fsync SCRATCH_MNT is enough.
Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
tests/generic/520 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/generic/520 b/tests/generic/520
index 167d7077..a16467ca 100755
--- a/tests/generic/520
+++ b/tests/generic/520
@@ -58,7 +58,7 @@ clean_dir()
{
_mount_flakey
rm -rf $(find $SCRATCH_MNT/* | grep -v "lost+found")
- sync
+ $XFS_IO_PROG -c "fsync" $SCRATCH_MNT
_unmount_flakey
}
--
2.18.0
next reply other threads:[~2019-12-13 5:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 5:45 Yang Xu [this message]
2019-12-13 20:42 ` [PATCH] generic/520: use fsync instead of sync during clean_dir Darrick J. Wong
2019-12-16 6:24 ` Yang Xu
2019-12-17 22:36 ` Darrick J. Wong
2019-12-18 2:37 ` Yang Xu
2019-12-19 17:08 ` Darrick J. Wong
2019-12-20 2:48 ` Yang Xu
2019-12-20 12:32 ` Filipe Manana
2019-12-23 5:01 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1576215941-19208-1-git-send-email-xuyang2018.jy@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).