From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: <darrick.wong@oracle.com>, <guaneryu@gmail.com>
Cc: <fstests@vger.kernel.org>, Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Subject: [PATCH v2] common/log: add -l su option in _xfs_log_config
Date: Thu, 20 Feb 2020 13:38:01 +0800 [thread overview]
Message-ID: <1582177081-6235-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> (raw)
In-Reply-To: <20200220021709.GF9504@magnolia>
Currently, if we don't specify -l sunit or -l su option, mkfs.xfs
will get the stripe size from underlying device.
It works file on most situations. But on some machine, the size of
underlying device greater than logbsize of mount options, it will
report error like "logbuf size must be greater than or equal to log
stripe size". We can specify -l su=4096 to meet this requirement and
case can still run normally.
Also, from xfs manpage, version 2 also supports 16k log buf size for
mount option and case passed(only generic/054,055 used this api) on
my machine. So delete 32k and 64k with different sunit to be consistented
with ext4 test num(10) and we can test all logbuf size.
Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
common/log | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/common/log b/common/log
index c7921f50..9b5a2f6d 100644
--- a/common/log
+++ b/common/log
@@ -546,15 +546,15 @@ _xfs_log_config()
{
echo "# mkfs-opt mount-opt"
echo "# ------------------------------"
- echo " version=2 logbsize=32k"
+ echo " version=2,su=4096 logbsize=16k"
+ echo " version=2,su=16k logbsize=16k"
echo " version=2,su=4096 logbsize=32k"
- echo " version=2,su=32768 logbsize=32k"
- echo " version=2,su=32768 logbsize=64k"
- echo " version=2 logbsize=64k"
+ echo " version=2,su=32k logbsize=32k"
+ echo " version=2,su=4096 logbsize=64k"
echo " version=2,su=64k logbsize=64k"
- echo " version=2 logbsize=128k"
+ echo " version=2,su=4096 logbsize=128k"
echo " version=2,su=128k logbsize=128k"
- echo " version=2 logbsize=256k"
+ echo " version=2,su=4096 logbsize=256k"
echo " version=2,su=256k logbsize=256k"
}
--
2.18.0
next prev parent reply other threads:[~2020-02-20 5:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 7:24 [PATCH v1 1/2] generic/054,055: add _require_v2log Yang Xu
2020-02-18 7:24 ` [PATCH v1 2/2] common/log: add 16k logbuf size for xfs_log_config Yang Xu
2020-02-19 5:06 ` [PATCH v1 1/2] generic/054,055: add _require_v2log Darrick J. Wong
2020-02-19 8:48 ` Yang Xu
2020-02-19 22:11 ` Darrick J. Wong
2020-02-20 2:01 ` Yang Xu
2020-02-20 2:17 ` Darrick J. Wong
2020-02-20 3:10 ` Yang Xu
2020-02-20 5:38 ` Yang Xu [this message]
2020-02-23 14:22 ` [PATCH v2] common/log: add -l su option in _xfs_log_config Eryu Guan
2020-02-23 16:37 ` Darrick J. Wong
2020-02-24 1:51 ` Yang Xu
2020-02-24 2:14 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582177081-6235-1-git-send-email-xuyang2018.jy@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).