From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me
Subject: [PATCH 4/4] generic/60[78]: ensure the initial DAX file flag state before test
Date: Tue, 02 Mar 2021 15:22:56 -0800 [thread overview]
Message-ID: <161472737624.3478298.18322455058303982173.stgit@magnolia> (raw)
In-Reply-To: <161472735404.3478298.8179031068431918520.stgit@magnolia>
From: Darrick J. Wong <djwong@kernel.org>
Since this test checks the behaviors of both the in-core S_DAX flag and
the ondisk FS_XFLAG_DAX inode flags, it must be careful about the
initial state of the filesystem w.r.t. the inode flag.
Make sure that the root directory does /not/ have the inode flag set
before we begin testing, so that the initial state doesn't throw off
inheritance testing.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
tests/generic/607 | 4 ++++
tests/generic/608 | 3 +++
2 files changed, 7 insertions(+)
diff --git a/tests/generic/607 b/tests/generic/607
index dd6dbd65..ba7da11b 100755
--- a/tests/generic/607
+++ b/tests/generic/607
@@ -156,6 +156,10 @@ do_xflag_tests()
local option=$1
_scratch_mount "$option"
+
+ # Make sure the root dir doesn't have FS_XFLAG_DAX set before we start.
+ chattr -x $SCRATCH_MNT &>> $seqres.full
+
cd $SCRATCH_MNT
for i in $(seq 1 5); do
diff --git a/tests/generic/608 b/tests/generic/608
index dd89d91c..13a751d7 100755
--- a/tests/generic/608
+++ b/tests/generic/608
@@ -98,6 +98,9 @@ do_tests()
_scratch_mount "$mount_option"
+ # Make sure the root dir doesn't have FS_XFLAG_DAX set before we start.
+ chattr -x $SCRATCH_MNT &>> $seqres.full
+
test_drop_caches
test_cycle_mount "$cycle_mount_option"
next prev parent reply other threads:[~2021-03-03 0:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 23:22 [PATCHSET 0/4] fstests: various fixes Darrick J. Wong
2021-03-02 23:22 ` [PATCH 1/4] generic/623: don't fail on core dumps Darrick J. Wong
2021-03-04 14:41 ` Chandan Babu R
2021-03-05 8:30 ` Christoph Hellwig
2021-03-02 23:22 ` [PATCH 2/4] xfs/271: fix test failure on non-reflink filesystems Darrick J. Wong
2021-03-04 15:42 ` Chandan Babu R
2021-03-05 8:31 ` Christoph Hellwig
2021-03-02 23:22 ` [PATCH 3/4] common/rc: fix detection of device-mapper/persistent memory incompatibility Darrick J. Wong
2021-03-05 8:25 ` Chandan Babu R
2021-03-05 8:33 ` Christoph Hellwig
2021-03-02 23:22 ` Darrick J. Wong [this message]
2021-03-05 8:35 ` [PATCH 4/4] generic/60[78]: ensure the initial DAX file flag state before test Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161472737624.3478298.18322455058303982173.stgit@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).