From: "Darrick J. Wong" <email@example.com> To: firstname.lastname@example.org, email@example.com Cc: Christoph Hellwig <firstname.lastname@example.org>, "Darrick J. Wong" <email@example.com>, Amir Goldstein <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com Subject: [PATCHSET v4 0/8] fstests: document all test groups Date: Thu, 16 Sep 2021 17:39:02 -0700 [thread overview] Message-ID: <163183914290.952957.11558799225344566504.stgit@magnolia> (raw) Hi all, I've noticed that fstests doesn't document what the test groups mean. I attempted to document what each group seems to symbolize, to reduce the amount of confusion for new contributors. While doing so, I noticed that there were a handful of tests that aren't in the right group. The first three patches dix that problem. The next test adds a build-time check to ensure that all groups are listed in the documentation file so that we don't lose track of things. The last patch updates ./new to use the documentation file instead of having to build group.list files. v2: fix the 'subvolume' group tests, tweak some of the wordings of the group description file, add missing license declarations, remove the one-off overlay group v2.1: move the group name documentation checks into the preamble code so we don't have to have a second script v3: cleanup cleanups to mkgroupfile and don't allow new 'other' group tests v4: split the ./new script cleanups into a separate series; add review tags; no other changes If you're going to start using this mess, you probably ought to just pull from my git trees, which are linked below. This is an extraordinary way to destroy everything. Enjoy! Comments and questions are, as always, welcome. --D fstests git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=document-test-groups --- common/preamble | 21 ++++++++ doc/group-names.txt | 135 +++++++++++++++++++++++++++++++++++++++++++++++++++ new | 24 ++++----- tests/btrfs/233 | 2 - tests/btrfs/245 | 2 - tests/ceph/001 | 2 - tests/ceph/002 | 2 - tests/ceph/003 | 2 - tests/generic/631 | 2 - tests/xfs/491 | 2 - tests/xfs/492 | 2 - tests/xfs/493 | 2 - tests/xfs/519 | 2 - tests/xfs/520 | 2 - tests/xfs/535 | 2 - tests/xfs/536 | 2 - tools/mkgroupfile | 37 +++++++++++--- tools/mvtest | 5 ++ tools/nextid | 4 +- 19 files changed, 215 insertions(+), 37 deletions(-) create mode 100644 doc/group-names.txt
next reply other threads:[~2021-09-17 0:39 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-17 0:39 Darrick J. Wong [this message] 2021-09-17 0:39 ` [PATCH 1/8] ceph: re-tag copy_file_range as being in the copy_range group Darrick J. Wong 2021-09-17 0:39 ` [PATCH 2/8] xfs: move reflink tests into the clone group Darrick J. Wong 2021-09-17 0:39 ` [PATCH 3/8] xfs: fix incorrect fuzz test group name Darrick J. Wong 2021-09-17 0:39 ` [PATCH 4/8] btrfs: fix incorrect subvolume " Darrick J. Wong 2021-09-17 0:39 ` [PATCH 5/8] generic/631: change this test to use the 'whiteout' group Darrick J. Wong 2021-09-17 0:39 ` [PATCH 6/8] tools: make sure that test groups are described in the documentation Darrick J. Wong 2021-09-17 0:39 ` [PATCH 7/8] tools: add missing license tags to my scripts Darrick J. Wong 2021-09-17 0:39 ` [PATCH 8/8] new: only allow documented test group names Darrick J. Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=163183914290.952957.11558799225344566504.stgit@magnolia \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCHSET v4 0/8] fstests: document all test groups' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).