From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me
Subject: [PATCH 2/4] common/xfs: fix broken code in _check_xfs_filesystem
Date: Tue, 15 Mar 2022 20:30:14 -0700 [thread overview]
Message-ID: <164740141477.3371628.6804259397500636490.stgit@magnolia> (raw)
In-Reply-To: <164740140348.3371628.12967562090320741592.stgit@magnolia>
From: Darrick J. Wong <djwong@kernel.org>
Fix some problems with undefined variables in the scrub control code.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
common/xfs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/xfs b/common/xfs
index 053b6189..ac1d021e 100644
--- a/common/xfs
+++ b/common/xfs
@@ -568,12 +568,12 @@ _check_xfs_filesystem()
# before executing a scrub operation.
$XFS_IO_PROG -c syncfs $mntpt >> $seqres.full 2>&1
- "$XFS_SCRUB_PROG" $scrubflag -v -d -n $mntpt > $tmp.scrub 2>&1
+ "$XFS_SCRUB_PROG" -v -d -n $mntpt > $tmp.scrub 2>&1
if [ $? -ne 0 ]; then
_log_err "_check_xfs_filesystem: filesystem on $device failed scrub"
- echo "*** xfs_scrub $scrubflag -v -d -n output ***" >> $seqres.full
+ echo "*** xfs_scrub -v -d -n output ***" >> $seqres.full
cat $tmp.scrub >> $seqres.full
- echo "*** end xfs_scrub output" >> $serqres.full
+ echo "*** end xfs_scrub output" >> $seqres.full
ok=0
fi
rm -f $tmp.scrub
next prev parent reply other threads:[~2022-03-16 3:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 3:30 [PATCHSET 0/4] fstests: random fixes Darrick J. Wong
2022-03-16 3:30 ` [PATCH 1/4] generic/459: ensure that the lvm devices have been created Darrick J. Wong
2022-03-22 4:50 ` Zorro Lang
2022-03-16 3:30 ` Darrick J. Wong [this message]
2022-03-22 4:57 ` [PATCH 2/4] common/xfs: fix broken code in _check_xfs_filesystem Zorro Lang
2022-03-16 3:30 ` [PATCH 3/4] xfs/420: fix occasional test failures due to pagecache readahead Darrick J. Wong
2022-03-22 5:13 ` Zorro Lang
2022-03-22 16:10 ` Darrick J. Wong
2022-03-16 3:30 ` [PATCH 4/4] generic/673: fix golden output to reflect vfs setgid behavior Darrick J. Wong
2022-03-22 5:24 ` Zorro Lang
2022-03-16 22:12 ` [PATCH 5/4] xfs/076: only create files on the data device Darrick J. Wong
2022-03-22 8:31 ` Zorro Lang
2022-03-16 22:13 ` [PATCH 6/4] xfs/17[035]: fix intermittent failures when filesystem metadata gets large Darrick J. Wong
2022-03-22 7:15 ` Zorro Lang
2022-03-22 16:11 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164740141477.3371628.6804259397500636490.stgit@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).