fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: ira.weiny@intel.com
Cc: fstests@vger.kernel.org, john.hubbard@gmail.com,
	Dave Chinner <david@fromorbit.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Jan Kara <jack@suse.cz>,
	dan.j.williams@intel.com, Jeff Layton <jlayton@kernel.org>
Subject: Re: [PATCH 00/13] Fix locktest and add lease testing to it
Date: Sun, 22 Sep 2019 00:20:48 +0800	[thread overview]
Message-ID: <20190921162048.GP2622@desktop> (raw)
In-Reply-To: <20190918041558.2621-1-ira.weiny@intel.com>

On Tue, Sep 17, 2019 at 09:15:45PM -0700, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> Rather than have a separate lease test, combine the previously proposed lease
> tests[1] directly to locktest because they share so much code.

Firstly, thanks for the revised version!

Then, I'm so sorry if I didn't explain clearly in previous review, we do
need a separate lease test, e.g. a new generic/568 test, and don't want
locktest.c to test both lock and lease in the same generic/131 case.
But reuse & extend the src/locktest.c to test lease as well, and call
src/locktest in the new generic/568 case.

e.g. introduce two test arrays, one for lock test and one for lease
test, and add new commandline switch to src/locktest.c and use the
correct test array according to the given commandline option.

> 
> To make things cleaner update the lock test code and test script.  This
> includes fixing a rather serious bug.
> 
> Finally update the error output to help identify any steps which fail during
> testing.
> 
> Ira
> 
> [1] https://www.spinics.net/lists/fstests/msg12467.html
> 
> Ira Weiny (13):
>   src/locktest: Remove unnecessary sleep
>   src/locktest: Remove OPEN macro
>   src/locktest: Change command macro names
>   src/locktest: Add get_cmd_str
>   src/locktest.c: Clean up client command passing
>   src/locktest.c: Fix return code if last test fails
>   generic/131: Clean up pid variables
>   generic/131: Save stderr for debugging

Looks like above cleanups and bugfixes can be merged independently, but
I'm not sure if you need to update them as well when introducing new
test array and new test case, so I leave them unmerged for now.

Thanks!

Eryu

>   src/locktest: Add simple lease testing
>   src/locktest: Add lease testing for basic signal reception
>   src/locktest: Add truncate lease tests
>   src/locktest: Clean up error output
>   src/locktest: Audit all debug output
> 
>  src/locktest.c    | 957 ++++++++++++++++++++++++++++++----------------
>  tests/generic/131 |  72 ++--
>  2 files changed, 666 insertions(+), 363 deletions(-)
> 
> -- 
> 2.20.1
> 

  parent reply	other threads:[~2019-09-21 16:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18  4:15 [PATCH 00/13] Fix locktest and add lease testing to it ira.weiny
2019-09-18  4:15 ` [PATCH 01/13] src/locktest: Remove unnecessary sleep ira.weiny
2019-09-18  4:15 ` [PATCH 02/13] src/locktest: Remove OPEN macro ira.weiny
2019-09-18  4:15 ` [PATCH 03/13] src/locktest: Change command macro names ira.weiny
2019-09-18  4:15 ` [PATCH 04/13] src/locktest: Add get_cmd_str ira.weiny
2019-09-18  4:15 ` [PATCH 05/13] src/locktest.c: Clean up client command passing ira.weiny
2019-09-18  4:15 ` [PATCH 06/13] src/locktest.c: Fix return code if last test fails ira.weiny
2019-09-18  4:15 ` [PATCH 07/13] generic/131: Clean up pid variables ira.weiny
2019-09-18  4:15 ` [PATCH 08/13] generic/131: Save stderr for debugging ira.weiny
2019-09-18  4:15 ` [PATCH 09/13] src/locktest: Add simple lease testing ira.weiny
2019-09-18  4:15 ` [PATCH 10/13] src/locktest: Add lease testing for basic signal reception ira.weiny
2019-09-18  4:15 ` [PATCH 11/13] src/locktest: Add truncate lease tests ira.weiny
2019-09-18  4:15 ` [PATCH 12/13] src/locktest: Clean up error output ira.weiny
2019-09-18  4:15 ` [PATCH 13/13] src/locktest: Audit all debug output ira.weiny
2019-09-20 13:12 ` [PATCH 00/13] Fix locktest and add lease testing to it Jeff Layton
2019-09-21 16:20 ` Eryu Guan [this message]
2019-09-22  2:01   ` Weiny, Ira
2019-09-22  7:52     ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190921162048.GP2622@desktop \
    --to=guaneryu@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=fstests@vger.kernel.org \
    --cc=ira.weiny@intel.com \
    --cc=jack@suse.cz \
    --cc=jgg@ziepe.ca \
    --cc=jlayton@kernel.org \
    --cc=john.hubbard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).