From: Eryu Guan <guaneryu@gmail.com>
To: Su Yanjun <suyj.fnst@cn.fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/442: add sync before dmsetup remove
Date: Wed, 25 Sep 2019 21:08:26 +0800 [thread overview]
Message-ID: <20190925130824.GU2622@desktop> (raw)
In-Reply-To: <1569400158-5297-1-git-send-email-suyj.fnst@cn.fujitsu.com>
On Wed, Sep 25, 2019 at 04:29:18PM +0800, Su Yanjun wrote:
> This test case sometime fails. Because "dmsetup remove error-test" may
> fail when some writeback is going on.
>
> This patch adds sync before dmsetup remove operation.
>
> Signed-off-by: Su Yanjun <suyj.fnst@cn.fujitsu.com>
> ---
> tests/generic/442 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/442 b/tests/generic/442
> index fe6d460..d48ca36 100755
> --- a/tests/generic/442
> +++ b/tests/generic/442
> @@ -43,6 +43,7 @@ $here/src/fsync-err -d $here/src/dmerror $DMERROR_DEV
fsync-err should have flipped $DMERROR_DEV to working mode and fsync
each open fd before exit if fsync-err didn't report any failure. So
there should be no on-going writeback.
>
> # success, all done
> _dmerror_load_working_table
> +sync
> _dmerror_cleanup
And _dmerror_cleanup umount $DMERROR_DEV first, then tear down the dm
device. Could you check if fsync-err returns successfully and umount
succeeds as well?
Thanks,
Eryu
> _scratch_mkfs > $seqres.full 2>&1
> status=0
> --
> 2.7.4
>
>
>
next prev parent reply other threads:[~2019-09-25 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 8:29 [PATCH] generic/442: add sync before dmsetup remove Su Yanjun
2019-09-25 13:08 ` Eryu Guan [this message]
2019-09-26 3:05 ` Su Yanjun
2019-09-26 5:51 ` Eryu Guan
2019-09-27 1:40 ` Su Yanjun
2019-09-27 1:40 ` Su Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925130824.GU2622@desktop \
--to=guaneryu@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=suyj.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).