From: Eryu Guan <eguan@linux.alibaba.com>
To: Ira Weiny <ira.weiny@intel.com>
Cc: fstests@vger.kernel.org, Eryu Guan <guaneryu@gmail.com>,
john.hubbard@gmail.com, Dave Chinner <david@fromorbit.com>,
Jan Kara <jack@suse.cz>, Jason Gunthorpe <jgg@ziepe.ca>,
dan.j.williams@intel.com, Jeff Layton <jlayton@kernel.org>
Subject: Re: [PATCH V2 00/16] Fix locktest and add lease testing to it
Date: Wed, 2 Oct 2019 16:24:29 +0800 [thread overview]
Message-ID: <20191002082429.GC67926@e18g06458.et15sqa> (raw)
In-Reply-To: <20191001215410.GA8840@iweiny-DESK2.sc.intel.com>
On Tue, Oct 01, 2019 at 02:54:10PM -0700, Ira Weiny wrote:
> On Mon, Sep 23, 2019 at 10:53:20AM -0700, 'Ira Weiny' wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > Add lease tests[1] to locktest because they share so much code. Make running
> > of lease tests separate as an '-L' option.
> >
> > To make things cleaner update the lock test code and test script. This
> > includes fixing a rather serious bug.
> >
> > Finally update the error output to help identify any steps which fail during
> > testing.
> >
>
> Was there any further feedback on this series? Did it get mangled too bad to
> apply?
Sorry, I forget to mention in last update announce that I'm on public
holiday this week and have limited internet access. I'll review this v2
when I get back.
>
> Ira
>
> >
> > Changes from V1:
> > Create a new option '-L' to run lease testing
> > Created 568 test script which shared common code with 131
> > Moved 2 patches earlier in the series
> > [PATCH V2 09/16] src/locktest: Clean up error output
> > [PATCH V2 10/16] src/locktest: Audit all debug output
> > Added 3 patches
> > [PATCH V2 11/16] src/locktest: Add run() function
> > [PATCH V2 15/16] common/locktest: Add common locktest functions
> > [PATCH V2 16/16] generic/568: Add lease testing
Thanks for the revision!
Eryu
> >
> > Ira Weiny (16):
> > src/locktest: Remove unnecessary sleep
> > src/locktest: Remove OPEN macro
> > src/locktest: Change command macro names
> > src/locktest: Add get_cmd_str
> > src/locktest.c: Clean up client command passing
> > src/locktest.c: Fix return code if last test fails
> > generic/131: Clean up pid variables
> > generic/131: Save stderr for debugging
> > src/locktest: Clean up error output
> > src/locktest: Audit all debug output
> > src/locktest: Add run() function
> > src/locktest: Add simple lease testing
> > src/locktest: Add lease testing for basic signal reception
> > src/locktest: Add truncate lease tests
> > common/locktest: Add common locktest functions
> > generic/568: Add lease testing
> >
> > common/locktest | 95 ++++
> > src/locktest.c | 999 +++++++++++++++++++++++++++---------------
> > tests/generic/131 | 54 +--
> > tests/generic/568 | 32 ++
> > tests/generic/568.out | 2 +
> > tests/generic/group | 1 +
> > 6 files changed, 786 insertions(+), 397 deletions(-)
> > create mode 100644 common/locktest
> > create mode 100755 tests/generic/568
> > create mode 100644 tests/generic/568.out
> >
> > --
> > 2.20.1
> >
next prev parent reply other threads:[~2019-10-02 8:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 17:53 [PATCH V2 00/16] Fix locktest and add lease testing to it ira.weiny
2019-09-23 17:53 ` [PATCH V2 01/16] src/locktest: Remove unnecessary sleep ira.weiny
2019-09-23 17:53 ` [PATCH V2 02/16] src/locktest: Remove OPEN macro ira.weiny
2019-09-23 17:53 ` [PATCH V2 03/16] src/locktest: Change command macro names ira.weiny
2019-09-23 17:53 ` [PATCH V2 04/16] src/locktest: Add get_cmd_str ira.weiny
2019-09-23 17:53 ` [PATCH V2 05/16] src/locktest.c: Clean up client command passing ira.weiny
2019-09-23 17:53 ` [PATCH V2 06/16] src/locktest.c: Fix return code if last test fails ira.weiny
2019-09-23 17:53 ` [PATCH V2 07/16] generic/131: Clean up pid variables ira.weiny
2019-09-23 17:53 ` [PATCH V2 08/16] generic/131: Save stderr for debugging ira.weiny
2019-09-23 17:53 ` [PATCH V2 09/16] src/locktest: Clean up error output ira.weiny
2019-09-23 17:53 ` [PATCH V2 10/16] src/locktest: Audit all debug output ira.weiny
2019-09-23 17:53 ` [PATCH V2 11/16] src/locktest: Add run() function ira.weiny
2019-09-23 17:53 ` [PATCH V2 12/16] src/locktest: Add simple lease testing ira.weiny
2019-09-23 17:53 ` [PATCH V2 13/16] src/locktest: Add lease testing for basic signal reception ira.weiny
2019-09-23 17:53 ` [PATCH V2 14/16] src/locktest: Add truncate lease tests ira.weiny
2019-09-23 17:59 ` [PATCH V2 15/16] common/locktest: Add common locktest functions ira.weiny
2019-09-23 17:59 ` [PATCH V2 16/16] generic/568: Add lease testing ira.weiny
2019-10-01 21:54 ` [PATCH V2 00/16] Fix locktest and add lease testing to it Ira Weiny
2019-10-02 8:24 ` Eryu Guan [this message]
2019-10-02 17:59 ` Ira Weiny
-- strict thread matches above, loose matches on Subject: below --
2019-09-23 17:51 ira.weiny
2019-09-23 17:58 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002082429.GC67926@e18g06458.et15sqa \
--to=eguan@linux.alibaba.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jlayton@kernel.org \
--cc=john.hubbard@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).