* [PATCH] generic/001: remove unnecessary backslash
@ 2019-10-09 5:34 Murphy Zhou
2019-10-09 7:00 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Murphy Zhou @ 2019-10-09 5:34 UTC (permalink / raw)
To: fstests; +Cc: Murphy Zhou
Awk 5.0.1 is complaining about this backslash and causing false alarm
like this:
warning: regexp escape sequence '\#' is not a known regexp operator
This fix works fine with Awk 3.1.7 , 4.0.2 , 4.2.1 and 5.0.1. This
backslash is not necessary.
Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
---
tests/generic/001 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/generic/001 b/tests/generic/001
index 046e54e3..3a047754 100755
--- a/tests/generic/001
+++ b/tests/generic/001
@@ -177,7 +177,7 @@ _chain()
{
$AWK_PROG -v full_file=$seqres.full -v verify=$verify <$tmp.config '
BEGIN { nfile = 0 }
-/^\#/ { next }
+/^#/ { next }
{ file[nfile] = $1
size[nfile] = $2
link[nfile] = 0
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] generic/001: remove unnecessary backslash
2019-10-09 5:34 [PATCH] generic/001: remove unnecessary backslash Murphy Zhou
@ 2019-10-09 7:00 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2019-10-09 7:00 UTC (permalink / raw)
To: Murphy Zhou; +Cc: fstests
On Wed, Oct 09, 2019 at 01:34:34PM +0800, Murphy Zhou wrote:
> Awk 5.0.1 is complaining about this backslash and causing false alarm
> like this:
> warning: regexp escape sequence '\#' is not a known regexp operator
>
> This fix works fine with Awk 3.1.7 , 4.0.2 , 4.2.1 and 5.0.1. This
> backslash is not necessary.
>
> Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-09 7:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 5:34 [PATCH] generic/001: remove unnecessary backslash Murphy Zhou
2019-10-09 7:00 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).