FSTests Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] generic/001: remove unnecessary backslash
@ 2019-10-09  5:34 Murphy Zhou
  2019-10-09  7:00 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Murphy Zhou @ 2019-10-09  5:34 UTC (permalink / raw)
  To: fstests; +Cc: Murphy Zhou

Awk 5.0.1 is complaining about this backslash and causing false alarm
like this:
    warning: regexp escape sequence '\#' is not a known regexp operator

This fix works fine with Awk 3.1.7 , 4.0.2 , 4.2.1 and 5.0.1. This
backslash is not necessary.

Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
---
 tests/generic/001 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/001 b/tests/generic/001
index 046e54e3..3a047754 100755
--- a/tests/generic/001
+++ b/tests/generic/001
@@ -177,7 +177,7 @@ _chain()
 {
     $AWK_PROG -v full_file=$seqres.full -v verify=$verify <$tmp.config '
 BEGIN	{ nfile = 0 }
-/^\#/	{ next }
+/^#/	{ next }
 	{ file[nfile] = $1
 	  size[nfile] = $2
 	  link[nfile] = 0
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] generic/001: remove unnecessary backslash
  2019-10-09  5:34 [PATCH] generic/001: remove unnecessary backslash Murphy Zhou
@ 2019-10-09  7:00 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2019-10-09  7:00 UTC (permalink / raw)
  To: Murphy Zhou; +Cc: fstests

On Wed, Oct 09, 2019 at 01:34:34PM +0800, Murphy Zhou wrote:
> Awk 5.0.1 is complaining about this backslash and causing false alarm
> like this:
>     warning: regexp escape sequence '\#' is not a known regexp operator
> 
> This fix works fine with Awk 3.1.7 , 4.0.2 , 4.2.1 and 5.0.1. This
> backslash is not necessary.
> 
> Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09  5:34 [PATCH] generic/001: remove unnecessary backslash Murphy Zhou
2019-10-09  7:00 ` Christoph Hellwig

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org linux-fstests@archiver.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/ public-inbox