From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Cc: fdmanana@gmail.com, fstests@vger.kernel.org
Subject: Re: [PATCH v2] generic/520: Remove sync in clean_dir
Date: Thu, 16 Jan 2020 07:35:52 -0800 [thread overview]
Message-ID: <20200116153552.GA2149943@magnolia> (raw)
In-Reply-To: <1577096499-23471-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>
On Mon, Dec 23, 2019 at 06:21:39PM +0800, Yang Xu wrote:
> When I test this case on xfs, it may fail as below:
> --------------------------------------------
> === link SCRATCH_MNT/A/foo SCRATCH_MNT/bar with fsync SCRATCH_MNT/A ===
> +umount: /mnt/xfstests/scratch: target is busy.
> + (In some cases useful info about processes that use
> + the device is found by lsof(8) or fuser(1))
> ---------------------------------------------
>
> It fails because somethings is still using the fs when we call sync and then
> try to unmount it. We can simply remove sync as the unmount is supposed to
> persist the file/directory removals.
/me continues to wonder why the target is busy in this case, but as the
sync truly isn't necessary:
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
> tests/generic/520 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/generic/520 b/tests/generic/520
> index 167d7077..d4457370 100755
> --- a/tests/generic/520
> +++ b/tests/generic/520
> @@ -58,7 +58,6 @@ clean_dir()
> {
> _mount_flakey
> rm -rf $(find $SCRATCH_MNT/* | grep -v "lost+found")
> - sync
> _unmount_flakey
> }
>
> --
> 2.18.0
>
>
>
next prev parent reply other threads:[~2020-01-16 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 10:21 [PATCH v2] generic/520: Remove sync in clean_dir Yang Xu
2020-01-16 9:28 ` Yang Xu
2020-01-16 15:35 ` Darrick J. Wong [this message]
2020-01-17 2:57 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116153552.GA2149943@magnolia \
--to=darrick.wong@oracle.com \
--cc=fdmanana@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=xuyang2018.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).