From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 309B1C33CA1 for ; Mon, 20 Jan 2020 07:09:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 103B22077C for ; Mon, 20 Jan 2020 07:09:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725872AbgATHJo (ORCPT ); Mon, 20 Jan 2020 02:09:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:34642 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbgATHJo (ORCPT ); Mon, 20 Jan 2020 02:09:44 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B51C6AF84; Mon, 20 Jan 2020 07:09:42 +0000 (UTC) From: Qu Wenruo To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: [PATCH 1/2] fstests: Always dump dmesg for failed test cases Date: Mon, 20 Jan 2020 15:09:37 +0800 Message-Id: <20200120070938.30247-1-wqu@suse.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org When hard-to-hit bugs happened, we really want every piece of info to help us debugging. Although we already have KEEP_DMESG config, not everyone is utilizing it, thus when hard-to-hit bugs happened, one could only set it and retry until next hit. This patch will change the behavior by always dumping the dmesg for failed tests, so that developers can always get extra info from any failure. Signed-off-by: Qu Wenruo --- check | 3 +++ 1 file changed, 3 insertions(+) diff --git a/check b/check index 2e148e5776e5..e580b2249f06 100755 --- a/check +++ b/check @@ -840,6 +840,9 @@ for section in $HOST_OPTIONS_SECTIONS; do # make sure we record the status of the last test we ran. if $err ; then + if [ ! -f $seqres.dmesg ]; then + _dmesg_since_test_start >$seqres.dmesg + fi bad="$bad $seqnum" n_bad=`expr $n_bad + 1` tc_status="fail" -- 2.24.1