FSTests Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] generic: require fibmap for testcases using filefrag
@ 2020-01-17  8:38 Murphy Zhou
  2020-01-17  8:45 ` Christoph Hellwig
  0 siblings, 1 reply; 7+ messages in thread
From: Murphy Zhou @ 2020-01-17  8:38 UTC (permalink / raw)
  To: fstests; +Cc: Murphy Zhou

To mute false alarm on NFS, which is reporting FIBMAP unsupported.

Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
---
 tests/generic/516 | 1 +
 tests/generic/540 | 1 +
 tests/generic/541 | 1 +
 tests/generic/542 | 1 +
 tests/generic/543 | 1 +
 tests/generic/578 | 1 +
 6 files changed, 6 insertions(+)

diff --git a/tests/generic/516 b/tests/generic/516
index ceaa4151..906e38ec 100755
--- a/tests/generic/516
+++ b/tests/generic/516
@@ -31,6 +31,7 @@ _cleanup()
 # real QA test starts here
 _supported_os Linux
 _require_test_dedupe
+_require_fibmap
 
 rm -f $seqres.full
 
diff --git a/tests/generic/540 b/tests/generic/540
index dc4d9485..242ab805 100755
--- a/tests/generic/540
+++ b/tests/generic/540
@@ -40,6 +40,7 @@ _cleanup()
 _supported_os Linux
 _supported_fs generic
 _require_scratch_reflink
+_require_fibmap
 _require_xfs_io_command "falloc"
 
 rm -f $seqres.full
diff --git a/tests/generic/541 b/tests/generic/541
index fcb5d567..ec7ed52a 100755
--- a/tests/generic/541
+++ b/tests/generic/541
@@ -40,6 +40,7 @@ _cleanup()
 _supported_os Linux
 _supported_fs generic
 _require_scratch_reflink
+_require_fibmap
 _require_xfs_io_command "falloc"
 
 rm -f $seqres.full
diff --git a/tests/generic/542 b/tests/generic/542
index 62b32cb5..62fc55ea 100755
--- a/tests/generic/542
+++ b/tests/generic/542
@@ -40,6 +40,7 @@ _cleanup()
 _supported_os Linux
 _supported_fs generic
 _require_scratch_reflink
+_require_fibmap
 _require_xfs_io_command "falloc"
 
 rm -f $seqres.full
diff --git a/tests/generic/543 b/tests/generic/543
index cc7ee532..75c2f7ef 100755
--- a/tests/generic/543
+++ b/tests/generic/543
@@ -40,6 +40,7 @@ _cleanup()
 _supported_os Linux
 _supported_fs generic
 _require_scratch_reflink
+_require_fibmap
 _require_xfs_io_command "falloc"
 
 rm -f $seqres.full
diff --git a/tests/generic/578 b/tests/generic/578
index 798cccf0..6e160142 100755
--- a/tests/generic/578
+++ b/tests/generic/578
@@ -29,6 +29,7 @@ _cleanup()
 # real QA test starts here
 _supported_os Linux
 _supported_fs generic
+_require_fibmap
 _require_test_program "mmap-write-concurrent"
 _require_command "$FILEFRAG_PROG" filefrag
 _require_test_reflink
-- 
2.20.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] generic: require fibmap for testcases using filefrag
  2020-01-17  8:38 [PATCH] generic: require fibmap for testcases using filefrag Murphy Zhou
@ 2020-01-17  8:45 ` Christoph Hellwig
  2020-01-17 10:02   ` Murphy Zhou
  0 siblings, 1 reply; 7+ messages in thread
From: Christoph Hellwig @ 2020-01-17  8:45 UTC (permalink / raw)
  To: Murphy Zhou; +Cc: fstests

On Fri, Jan 17, 2020 at 04:38:24PM +0800, Murphy Zhou wrote:
> To mute false alarm on NFS, which is reporting FIBMAP unsupported.

How do these tests end up using FIBMAP?  We really should not use FIBMAP
in any tests except those exercising FIBMAP itself.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] generic: require fibmap for testcases using filefrag
  2020-01-17  8:45 ` Christoph Hellwig
@ 2020-01-17 10:02   ` Murphy Zhou
  2020-01-18  0:47     ` Darrick J. Wong
  0 siblings, 1 reply; 7+ messages in thread
From: Murphy Zhou @ 2020-01-17 10:02 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Murphy Zhou, fstests

On Fri, Jan 17, 2020 at 12:45:17AM -0800, Christoph Hellwig wrote:
> On Fri, Jan 17, 2020 at 04:38:24PM +0800, Murphy Zhou wrote:
> > To mute false alarm on NFS, which is reporting FIBMAP unsupported.
> 
> How do these tests end up using FIBMAP?  We really should not use FIBMAP
> in any tests except those exercising FIBMAP itself.
> 
Through filefrag(8)?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] generic: require fibmap for testcases using filefrag
  2020-01-17 10:02   ` Murphy Zhou
@ 2020-01-18  0:47     ` Darrick J. Wong
  2020-01-18  9:38       ` Murphy Zhou
  0 siblings, 1 reply; 7+ messages in thread
From: Darrick J. Wong @ 2020-01-18  0:47 UTC (permalink / raw)
  To: Murphy Zhou; +Cc: Christoph Hellwig, fstests

On Fri, Jan 17, 2020 at 06:02:30PM +0800, Murphy Zhou wrote:
> On Fri, Jan 17, 2020 at 12:45:17AM -0800, Christoph Hellwig wrote:
> > On Fri, Jan 17, 2020 at 04:38:24PM +0800, Murphy Zhou wrote:
> > > To mute false alarm on NFS, which is reporting FIBMAP unsupported.
> > 
> > How do these tests end up using FIBMAP?  We really should not use FIBMAP
> > in any tests except those exercising FIBMAP itself.
> > 
> Through filefrag(8)?

But do those tests require filefrag -B??

--D

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] generic: require fibmap for testcases using filefrag
  2020-01-18  0:47     ` Darrick J. Wong
@ 2020-01-18  9:38       ` Murphy Zhou
  2020-01-19 22:02         ` Christoph Hellwig
  0 siblings, 1 reply; 7+ messages in thread
From: Murphy Zhou @ 2020-01-18  9:38 UTC (permalink / raw)
  To: Darrick J. Wong; +Cc: Murphy Zhou, Christoph Hellwig, fstests

On Fri, Jan 17, 2020 at 04:47:00PM -0800, Darrick J. Wong wrote:
> On Fri, Jan 17, 2020 at 06:02:30PM +0800, Murphy Zhou wrote:
> > On Fri, Jan 17, 2020 at 12:45:17AM -0800, Christoph Hellwig wrote:
> > > On Fri, Jan 17, 2020 at 04:38:24PM +0800, Murphy Zhou wrote:
> > > > To mute false alarm on NFS, which is reporting FIBMAP unsupported.
> > > 
> > > How do these tests end up using FIBMAP?  We really should not use FIBMAP
> > > in any tests except those exercising FIBMAP itself.
> > > 
> > Through filefrag(8)?
> 
> But do those tests require filefrag -B??

Not really. But filefrag will fall back to use fibmap.

> 
> --D

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] generic: require fibmap for testcases using filefrag
  2020-01-18  9:38       ` Murphy Zhou
@ 2020-01-19 22:02         ` Christoph Hellwig
  2020-01-22 10:22           ` Murphy Zhou
  0 siblings, 1 reply; 7+ messages in thread
From: Christoph Hellwig @ 2020-01-19 22:02 UTC (permalink / raw)
  To: Murphy Zhou; +Cc: Darrick J. Wong, Christoph Hellwig, fstests

On Sat, Jan 18, 2020 at 05:38:51PM +0800, Murphy Zhou wrote:
> > But do those tests require filefrag -B??
> 
> Not really. But filefrag will fall back to use fibmap.

But that means it requires either FIEMAP or FIBMAP, and your patch
will cause regressions for file systems only implementing FIEMAP.
So the fix isn't to ask for FIBMAP, but to implement FIEMAP in
any file system missing that support.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] generic: require fibmap for testcases using filefrag
  2020-01-19 22:02         ` Christoph Hellwig
@ 2020-01-22 10:22           ` Murphy Zhou
  0 siblings, 0 replies; 7+ messages in thread
From: Murphy Zhou @ 2020-01-22 10:22 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Murphy Zhou, Darrick J. Wong, fstests

On Sun, Jan 19, 2020 at 02:02:52PM -0800, Christoph Hellwig wrote:
> On Sat, Jan 18, 2020 at 05:38:51PM +0800, Murphy Zhou wrote:
> > > But do those tests require filefrag -B??
> > 
> > Not really. But filefrag will fall back to use fibmap.
> 
> But that means it requires either FIEMAP or FIBMAP, and your patch
> will cause regressions for file systems only implementing FIEMAP.
> So the fix isn't to ask for FIBMAP, but to implement FIEMAP in
> any file system missing that support.

Hmm, you are right :-)

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17  8:38 [PATCH] generic: require fibmap for testcases using filefrag Murphy Zhou
2020-01-17  8:45 ` Christoph Hellwig
2020-01-17 10:02   ` Murphy Zhou
2020-01-18  0:47     ` Darrick J. Wong
2020-01-18  9:38       ` Murphy Zhou
2020-01-19 22:02         ` Christoph Hellwig
2020-01-22 10:22           ` Murphy Zhou

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git