From: Eryu Guan <guaneryu@gmail.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/3] generic/521: add close+open operations to the fsx run
Date: Sat, 1 Feb 2020 16:06:47 +0800 [thread overview]
Message-ID: <20200201080644.GC2697@desktop> (raw)
In-Reply-To: <20200107165542.70108-4-josef@toxicpanda.com>
On Tue, Jan 07, 2020 at 11:55:42AM -0500, Josef Bacik wrote:
> I was fixing a issue with i_size setting in btrfs and generic/521 was
> what I used to reproduce the problem. However I needed the close+open
> operation to trigger the issue. This is a soak test, so add this
> option to increase the coverage of this test.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
> tests/generic/521 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/521 b/tests/generic/521
> index e8bc36e4..f0fc575e 100755
> --- a/tests/generic/521
> +++ b/tests/generic/521
> @@ -52,6 +52,7 @@ fsx_args+=(-r $min_dio_sz)
> fsx_args+=(-t $min_dio_sz)
> fsx_args+=(-w $min_dio_sz)
> fsx_args+=(-Z)
> +fsx_args+=(-c 10)
This looks fine to me, but my only concern is that this floods dmesg
because every drop cache records a dmesg info, and the useful part of
dmesg may be lost. How about "-c 10000"? As the default op number is 1
million, with "-c 10000" we only have 100 dmesg entries. But I'm not
sure if that's enough for you to reproduce the bug.
Thanks,
Eryu
>
> run_fsx "${fsx_args[@]}" | sed -e '/^fsx.*/d'
>
> --
> 2.23.0
>
prev parent reply other threads:[~2020-02-01 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 16:55 [PATCH 0/3] Some fsx improvements Josef Bacik
2020-01-07 16:55 ` [PATCH 1/3] ltp/fsx: do size check after closeopen operation Josef Bacik
2020-02-01 7:42 ` Eryu Guan
2020-01-07 16:55 ` [PATCH 2/3] ltp/fsx: drop caches if we're doing closeopen Josef Bacik
2020-01-07 16:55 ` [PATCH 3/3] generic/521: add close+open operations to the fsx run Josef Bacik
2020-02-01 8:06 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200201080644.GC2697@desktop \
--to=guaneryu@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).