From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 7/7] xfs/020: call _notrun if we can't create a 60t sparse image
Date: Sun, 2 Feb 2020 11:54:18 -0800 [thread overview]
Message-ID: <20200202195418.GD6869@magnolia> (raw)
In-Reply-To: <157915147960.2374854.2067220014390694914.stgit@magnolia>
On Wed, Jan 15, 2020 at 09:11:19PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> If we can't create the 60T sparse image for testing repair on a large fs
> (such as when running on 32-bit), don't bother running the rest of the
> test.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/xfs/020 | 2 ++
> 1 file changed, 2 insertions(+)
>
>
> diff --git a/tests/xfs/020 b/tests/xfs/020
> index 61da4101..e39c3482 100755
> --- a/tests/xfs/020
> +++ b/tests/xfs/020
> @@ -42,6 +42,8 @@ echo "Silence is golden"
>
> fsfile=$TEST_DIR/fsfile.$seq
> rm -f $fsfile
> +truncate -s 60t $fsfile || _notrun "Cannot create 60T sparse file for test."
Um, this got committed with "xfs_io -x -c 'truncate 60t' and not as
written, which means that this test does not work on i386 because xfs_io
doesn't return nonzero when the truncate syscall fails. Will send
patch.
--D
> +rm -f $fsfile
>
> $MKFS_PROG -t xfs -d size=60t,file,name=$fsfile >/dev/null
> $XFS_REPAIR_PROG -f -o ag_stride=32 -t 1 $fsfile >/dev/null 2>&1
>
prev parent reply other threads:[~2020-02-02 19:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 5:10 [PATCH 0/7] fstests: random fixes Darrick J. Wong
2020-01-16 5:10 ` [PATCH 1/7] xfs/449: filter out "Discarding..." from output Darrick J. Wong
2020-01-16 9:23 ` Christoph Hellwig
2020-01-16 5:10 ` [PATCH 2/7] xfs/122: add disk dquot structure to the list Darrick J. Wong
2020-01-16 9:23 ` Christoph Hellwig
2020-01-16 5:10 ` [PATCH 3/7] xfs/507: skip if we can't create a large sparse file for testing Darrick J. Wong
2020-01-16 9:24 ` Christoph Hellwig
2020-01-16 5:11 ` [PATCH 4/7] xfs/279: skip test if we can't allocate scsi_debug device Darrick J. Wong
2020-01-16 9:24 ` Christoph Hellwig
2020-01-16 5:11 ` [PATCH 5/7] rc: fix _get_max_lfs_filesize on 32-bit platforms Darrick J. Wong
2020-01-16 9:25 ` Christoph Hellwig
2020-01-16 5:11 ` [PATCH 6/7] generic/108: skip test if we can't initialize scsi_debug Darrick J. Wong
2020-01-16 9:25 ` Christoph Hellwig
2020-01-16 5:11 ` [PATCH 7/7] xfs/020: call _notrun if we can't create a 60t sparse image Darrick J. Wong
2020-01-16 9:25 ` Christoph Hellwig
2020-02-02 19:54 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200202195418.GD6869@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).