fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: Christian Kujau <lists@nerdbynature.de>
Cc: fstests@vger.kernel.org
Subject: Re: shared/032: add options for reiser4
Date: Mon, 17 Feb 2020 20:47:41 +0800	[thread overview]
Message-ID: <20200217124738.GK2697@desktop> (raw)
In-Reply-To: <alpine.DEB.2.22.395.2001311244100.2831@trent.utfs.org>

On Fri, Jan 31, 2020 at 12:55:47PM -0800, Christian Kujau wrote:
> Last night I had xfstests running and after a while it hung at shared/032 
> because I had reiser4progs installed and it was waiting for input:
> 
> -----------------------------------------------------------------
> mkfs -t reiser4 /dev/ram0
> mkfs.reiser4 1.2.1
> Format release: 4.0.2
> Copyright (C) 2001-2005 by Hans Reiser, licensing governed by 
> reiser4progs/COPYING. 
> 
> Block size 4096 will be used.                                                                                                                                                                         
> Linux 5.5.0-rc5-amd64 is detected.                                                                                                                                                                    
> Uuid 2006a590-832a-49f5-9317-cf91bf866dd7 will be used.                                                                                                                                               
> Reiser4 is going to be created on /dev/ram0.                                                                                                                                                          
> (Yes/No): 
> -----------------------------------------------------------------
> 
> The patch below adds an option (cf. reiserfs the line above) so that the 
> test continues.
> 
> Curiously enough the test still "succeeds" for reiser{fs,4} (and jfs too) 
> because the userspace tools don't appear to have a routine to check for 
> "contains an existing filesystem", but that could be addressed in a 
> different patch.
> 
> Signed-off-by: Christian Kujau <lists@nerdbynature.de>

Thanks for the patch! But This patch cannot be applied, seems the format
is wrong.

But it's easy enough to apply manually, just please make sure the patch
format is correct next time.

Thanks,
Eryu

> 
> --- tests/shared/032.orig	2020-01-12 08:43:34.000000000 -0800
> +++ tests/shared/032	2020-01-31 12:30:27.158763104 -0800
> @@ -49,6 +49,7 @@
>  	[ $fs = gfs ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
>  	[ $fs = gfs2 ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
>  	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
> +	[ $fs = reiser4 ] && preop="echo y |" && preargs="-f"
>  	# cramfs mkfs requires a directory argument
>  	[ $fs = cramfs ] && preargs=/proc/fs
>  	[ $fs = ext2 ] && preargs="-F"
> 
> -- 
> BOFH excuse #164:
> 
> root rot

  reply	other threads:[~2020-02-17 12:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31 20:55 shared/032: add options for reiser4 Christian Kujau
2020-02-17 12:47 ` Eryu Guan [this message]
2020-02-19  0:29   ` Christian Kujau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200217124738.GK2697@desktop \
    --to=guaneryu@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=lists@nerdbynature.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).