fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/029: filter out "extended-header: cycle: 1" from output
Date: Tue, 18 Feb 2020 16:32:04 -0800	[thread overview]
Message-ID: <20200219003204.GA9511@magnolia> (raw)
In-Reply-To: <1581922940-14074-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>

On Mon, Feb 17, 2020 at 03:02:20PM +0800, Yang Xu wrote:
> When I test this case under GPT disklabel type, this case will fail,
> as below:
> cycle: 1        version: 2              lsn: 1,0        tail_lsn: 1,0
> length of Log Record: 258048    prev offset: -1         num ops: 1
> 
> ...
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> extended-header: cycle: 1
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ...
> 
> my mkfs information as below:
> meta-data=/dev/sda7              isize=512    agcount=16, agsize=327680 blks
>          =                       sectsz=512   attr=2, projid32bit=1
>          =                       crc=1        finobt=1, sparse=1, rmapbt=0
>          =                       reflink=1
> data     =                       bsize=4096   blocks=5242880, imaxpct=25
>          =                       sunit=64     swidth=64 blks
> naming   =version 2              bsize=4096   ascii-ci=0, ftype=1
> log      =internal log           bsize=4096   blocks=5184, version=2
>          =                       sectsz=512   sunit=64 blks, lazy-count=1
> realtime =none                   extsz=4096   blocks=0, rtextents=0
> 
> It reports this info because xfs_logprint only read 32k header every time, so it
> needs to read more times. We can filter this useless info.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
>  tests/xfs/029 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/029 b/tests/xfs/029
> index f532a21b..99742792 100755
> --- a/tests/xfs/029
> +++ b/tests/xfs/029
> @@ -45,7 +45,7 @@ echo
>  _scratch_mkfs_xfs | _filter_mkfs 2>/dev/null
>  
>  echo
> -_scratch_xfs_logprint | _filter_logprint
> +_scratch_xfs_logprint | _filter_logprint | sed -e "/^~~~/d" -e "/extended-header/d"

Is there a reason not to add that to _filter_logprint?

--D

>  
>  status=0
>  exit
> -- 
> 2.18.0
> 
> 
> 

  reply	other threads:[~2020-02-19  0:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17  7:02 [PATCH] xfs/029: filter out "extended-header: cycle: 1" from output Yang Xu
2020-02-19  0:32 ` Darrick J. Wong [this message]
2020-02-19  1:27   ` Yang Xu
2020-02-19  5:07     ` Darrick J. Wong
2020-02-19  9:49       ` Yang Xu
2020-02-19 22:09         ` Darrick J. Wong
2020-02-20  2:11           ` Yang Xu
2020-02-20  7:58           ` [PATCH v2 1/2] " Yang Xu
2020-02-20  7:58             ` [PATCH v2 2/2] xfs/044: Remove useless _filter_logprint Yang Xu
2020-02-20 23:30               ` Darrick J. Wong
2020-02-20 23:30             ` [PATCH v2 1/2] xfs/029: filter out "extended-header: cycle: 1" from output Darrick J. Wong
2020-02-21  1:45               ` Yang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200219003204.GA9511@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=xuyang2018.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).