From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2EB6C34022 for ; Wed, 19 Feb 2020 05:06:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9572424656 for ; Wed, 19 Feb 2020 05:06:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="uJ10mS7f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725842AbgBSFGc (ORCPT ); Wed, 19 Feb 2020 00:06:32 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:38270 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725306AbgBSFGc (ORCPT ); Wed, 19 Feb 2020 00:06:32 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01J540L1026475; Wed, 19 Feb 2020 05:06:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=NZmgLVKqfWNo5+iDOToGSzT45pJTMaMtGR1nu2giayE=; b=uJ10mS7fzv4cqHKPEi81YtAYZLRuUWY7QnWHbC6GolJORv6wgZ5jqmaaJ1T9uiCnMCFX i4SjBRk2WjDMgeUQpPrryAga0NaWfFUfRth2sAFRGtqqGnuiogQXe8CdOTupNA0cdB8z k+OpyxfJMWOkfyryj2gSUThmK++wTCGy0j2b+MYaFKxa1lZ9iNnJRy57hDUi8q08UU+E 7vbRSE/GJRgYeLfKTnKr5rUt6rvCc+gr/YfLYbxZ3TKq4ztui9lvOQE61BQwXF8ag2j3 J51H3rcNgBL2zwUZLf+jcLtFwaGJEH8RplqS+IwrLkbknlJ3BZ/AL3uJUvlfm5zzLVuM 0A== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2y8ud10jvs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Feb 2020 05:06:24 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01J51pWA148792; Wed, 19 Feb 2020 05:06:24 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2y8ud29cg2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Feb 2020 05:06:24 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 01J56NC0021782; Wed, 19 Feb 2020 05:06:23 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 18 Feb 2020 21:06:22 -0800 Date: Tue, 18 Feb 2020 21:06:22 -0800 From: "Darrick J. Wong" To: Yang Xu Cc: guaneryu@gmail.com, fstests@vger.kernel.org Subject: Re: [PATCH v1 1/2] generic/054,055: add _require_v2log Message-ID: <20200219050622.GB9504@magnolia> References: <1582010652-1124-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1582010652-1124-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9535 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002190033 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9535 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 bulkscore=0 spamscore=0 priorityscore=1501 phishscore=0 impostorscore=0 mlxlogscore=999 clxscore=1015 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002190033 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Tue, Feb 18, 2020 at 03:24:10PM +0800, Yang Xu wrote: > This two case fail on my server machine with GPT disklabe type, > info as below: > mount failed: -o logbsize=32k > dmesg info as below: > [92633.871954] XFS (sda7): logbuf size must be greater than or equal to log stripe size > > The min logbuf size is 256k on my server machine. It needs to use _require_v2log to check. Works fine here. What is sda7's storage and raid alignment configuration? --D > Signed-off-by: Yang Xu > --- > common/log | 1 + > tests/generic/054 | 1 + > tests/generic/055 | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/common/log b/common/log > index c7921f50..f82919a6 100644 > --- a/common/log > +++ b/common/log > @@ -494,6 +494,7 @@ _log_version() > > _require_v2log() > { > + [ "$FSTYP" != xfs ] && return 0 > # test out mkfs to see if it supports "-l version=2" > export MKFS_OPTIONS="-l version=2" > if ! _scratch_mkfs_xfs >>$seqres.full 2>&1; then > diff --git a/tests/generic/054 b/tests/generic/054 > index 95d40c3c..b4b74615 100755 > --- a/tests/generic/054 > +++ b/tests/generic/054 > @@ -30,6 +30,7 @@ rm -f $seqres.full $tmp.* > _require_scratch > _require_scratch_shutdown > _require_logstate > +_require_v2log > > echo "*** init FS" > _scratch_unmount >/dev/null 2>&1 > diff --git a/tests/generic/055 b/tests/generic/055 > index 9715f27b..071c4eaf 100755 > --- a/tests/generic/055 > +++ b/tests/generic/055 > @@ -57,6 +57,7 @@ rm -f $seqres.full $tmp.* > _require_scratch > _require_scratch_shutdown > _require_logstate > +_require_v2log > > QUOTA_OPTION=`_get_quota_option` > > -- > 2.18.0 > > >