fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@redhat.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] generic: per-type quota timers set/get test
Date: Thu, 20 Feb 2020 13:05:59 +0800	[thread overview]
Message-ID: <20200220050559.GG14282@dhcp-12-102.nay.redhat.com> (raw)
In-Reply-To: <605d6c45-9f52-ec84-df01-d5b7665d16dc@sandeen.net>

On Wed, Feb 19, 2020 at 10:23:29PM -0600, Eric Sandeen wrote:
> 
> 
> On 2/19/20 10:15 PM, Zorro Lang wrote:
> > On Wed, Feb 19, 2020 at 08:57:58PM -0600, Eric Sandeen wrote:
> >> On 2/16/20 12:16 PM, Zorro Lang wrote:
> >>> --- /dev/null
> >>> +++ b/tests/generic/593.out
> >>> @@ -0,0 +1,32 @@
> >>> +QA output created by 593
> >>> +1. set project quota timer
> >>> +*** Report for user quotas on device SCRATCH_DEV
> >>> +Block grace time: 7days; Inode grace time: 7days
> >>> +*** Report for group quotas on device SCRATCH_DEV
> >>> +Block grace time: 7days; Inode grace time: 7days
> >>> +*** Report for project quotas on device SCRATCH_DEV
> >>> +Block grace time: 00:10; Inode grace time: 00:20
> >>
> >> One other thing that might be an issue here, I'm not sure every
> >> filesystem will default to 7 days if no other grace period is set ...?
> > 
> > Make sense:) I just hope to test the default grace time by pass.
> > How about:
> > 1) Get the default quota timer $string.
> > 2) Filter above default timer "$string" to "default".
> > to avoid defferent default timer breaks the golden output.
> 
> Makes sense to me, at least after I fix the other xfs bugs ;)

Yeah, I just reviewed your patch:
  [PATCH] xfs: test that default grace periods init on first mount

I think my case hard to cover this situation, I have to filter the default
value, but if the default value is bad from beginning, it can't help :)

Thanks,
Zorro

> 
> -Eric
> 


      parent reply	other threads:[~2020-02-20  4:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-16 18:16 [PATCH 1/2] generic: per-type quota timers set/get test Zorro Lang
2020-02-16 18:16 ` [PATCH 2/2] generic: test per-type quota softlimit enforcement timeout Zorro Lang
2020-02-18 21:09 ` [PATCH 1/2] generic: per-type quota timers set/get test Eric Sandeen
2020-02-18 21:41 ` Eric Sandeen
2020-02-18 21:44   ` Eric Sandeen
2020-02-18 22:02     ` Eric Sandeen
2020-02-20  2:57 ` Eric Sandeen
2020-02-20  4:15   ` Zorro Lang
     [not found]     ` <605d6c45-9f52-ec84-df01-d5b7665d16dc@sandeen.net>
2020-02-20  5:05       ` Zorro Lang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200220050559.GG14282@dhcp-12-102.nay.redhat.com \
    --to=zlang@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).