From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1FD2C3F2D1 for ; Fri, 6 Mar 2020 01:33:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD8C12073D for ; Fri, 6 Mar 2020 01:33:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726271AbgCFBdK (ORCPT ); Thu, 5 Mar 2020 20:33:10 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:42703 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726191AbgCFBdK (ORCPT ); Thu, 5 Mar 2020 20:33:10 -0500 Received: from callcc.thunk.org (guestnat-104-133-0-105.corp.google.com [104.133.0.105] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 0261WxcD006661 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Mar 2020 20:32:59 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id F3BC242045B; Thu, 5 Mar 2020 20:32:58 -0500 (EST) Date: Thu, 5 Mar 2020 20:32:58 -0500 From: "Theodore Y. Ts'o" To: "zhangyi (F)" Cc: fstests@vger.kernel.org, guaneryu@gmail.com, linux-ext4@vger.kernel.org Subject: Re: [PATCH v2] ext4/021: make sure the fdatasync subprocess exits Message-ID: <20200306013258.GL20967@mit.edu> References: <20200226032256.10978-1-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226032256.10978-1-yi.zhang@huawei.com> Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Wed, Feb 26, 2020 at 11:22:56AM +0800, zhangyi (F) wrote: > Now we just kill fdatasync_work process and wait nothing after the > test, so a busy unmount failure may appear if the fdatasync syscall > doesn't return in time. > > umount: /tmp/scratch: target is busy. > mount: /tmp/scratch: /dev/sdb already mounted on /tmp/scratch. > !!! failed to remount /dev/sdb on /tmp/scratch > > This patch wait the xfs_io fdatasync subprocess exit to make sure > _check_scratch_fs success. > > Signed-off-by: zhangyi (F) Looks good, thanks! Reviewed-by: Theodore Ts'o