FSTests Archive on lore.kernel.org
 help / color / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Chandan Rajendra <chandanrlinux@gmail.com>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org,
	chandan@linux.ibm.com
Subject: Re: [PATCH] common/xfs: Execute _xfs_check only for block size <= 4k
Date: Wed, 25 Mar 2020 06:12:13 -0700
Message-ID: <20200325131213.GA22350@infradead.org> (raw)
In-Reply-To: <20200324034729.32678-1-chandanrlinux@gmail.com>

On Tue, Mar 24, 2020 at 09:17:29AM +0530, Chandan Rajendra wrote:
> fsstress when executed as part of some of the tests (e.g. generic/270)
> invokes chown() syscall many times by passing random integers as value
> for the uid argument. For each such syscall invocation for which there
> is no on-disk quota block, xfs invokes xfs_dquot_disk_alloc() which
> allocates a new block and instantiates all the quota structures mapped
> by the newly allocated block. For a single 64k block, the number of
> on-disk quota structures thus created will be 16 times more than that
> for a 4k block.
> 
> xfs_db's check command (executed after test script finishes execution)
> will read in all of the on-disk quota structures into memory. This
> causes the OOM event to be triggered when reading from filesystems with
> 64k block size. For machines with sufficiently large amount of system
> memory, this causes the test to execute for a very long time.
> 
> Due to the above stated reasons, this commit disables execution of
> xfs_db's check command when working on 64k blocksized filesystem.

Due to all the scalability issues in the xfs_db check command I think
it finally is time to just not run it by default at all.

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-24  3:47 Chandan Rajendra
2020-03-25 13:12 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200325131213.GA22350@infradead.org \
    --to=hch@infradead.org \
    --cc=chandan@linux.ibm.com \
    --cc=chandanrlinux@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git