fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] 270: wait for fsstress processes to be killed
@ 2020-06-15 10:52 Lukas Czerner
  0 siblings, 0 replies; only message in thread
From: Lukas Czerner @ 2020-06-15 10:52 UTC (permalink / raw)
  To: fstests

Currently wait will do nothing, because $pid is empty due to the fact
that the command was ran on the background in a separate shell so we
never got the $! set.

This is causing unexpected test failures especially under low memory
due to the fact that the fsstress is still running when we are
checking and comparing quota usage.

Fix it by using -w argument for killall that will wait for all processes
to actually die before it exits.

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
 tests/generic/270 | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/generic/270 b/tests/generic/270
index 5092ffa4..55779f5e 100755
--- a/tests/generic/270
+++ b/tests/generic/270
@@ -38,7 +38,6 @@ _workout()
 	$SETCAP_PROG cap_chown=epi  $tmp.fsstress.bin
 
 	(su $qa_user -c "$tmp.fsstress.bin $args" &) > /dev/null 2>&1
-	pid=$!
 
 	echo "Run dd writers in parallel"
 	for ((i=0; i < num_iterations; i++))
@@ -50,8 +49,7 @@ _workout()
 		sleep $enospc_time
 	done
 
-	$KILLALL_PROG $tmp.fsstress.bin
-	wait $pid
+	$KILLALL_PROG -w $tmp.fsstress.bin
 }
 
 # real QA test starts here
-- 
2.21.3


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-15 10:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15 10:52 [PATCH] 270: wait for fsstress processes to be killed Lukas Czerner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).