From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD9A1C433DF for ; Tue, 30 Jun 2020 15:50:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0842206C3 for ; Tue, 30 Jun 2020 15:50:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389767AbgF3Pu7 (ORCPT ); Tue, 30 Jun 2020 11:50:59 -0400 Received: from mga03.intel.com ([134.134.136.65]:34202 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389710AbgF3Pu7 (ORCPT ); Tue, 30 Jun 2020 11:50:59 -0400 IronPort-SDR: Z8jTi0l3O1rP+ZpT2AWOyO/fKV/AgPlF5sJOQwgSEzsP0411s11+V+intSYtWz57TySwQuHlM1 Jn4xhyZ7xe6Q== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="146266558" X-IronPort-AV: E=Sophos;i="5.75,297,1589266800"; d="scan'208";a="146266558" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2020 08:50:58 -0700 IronPort-SDR: Fn1adMiaI07vH7MxD/iFCZXTnfBxX8u1ndyMfgFNKTBpceiP9AxzV/RvjhiHzCJO0IXb0QmOEu K7ePsG2xW4IQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,297,1589266800"; d="scan'208";a="312405036" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by orsmga008.jf.intel.com with ESMTP; 30 Jun 2020 08:50:58 -0700 Date: Tue, 30 Jun 2020 08:50:58 -0700 From: Ira Weiny To: Xiao Yang Cc: Xiao Yang , fstests@vger.kernel.org, darrick.wong@oracle.com Subject: Re: [PATCH v2 6/6] xfs/260: Move xfs/260 to generic Message-ID: <20200630155058.GT2617015@iweiny-DESK2.sc.intel.com> References: <20200617093204.20838-1-ice_yangxiao@163.com> <20200617093204.20838-7-ice_yangxiao@163.com> <20200617214857.GN4160762@iweiny-DESK2.sc.intel.com> <20200619151511.GR4160762@iweiny-DESK2.sc.intel.com> <5EF1C293.4010104@cn.fujitsu.com> <20200623180803.GE3910394@iweiny-DESK2.sc.intel.com> <5EFAE502.6060805@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5EFAE502.6060805@cn.fujitsu.com> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Tue, Jun 30, 2020 at 03:08:50PM +0800, Xiao Yang wrote: > On 2020/6/24 2:08, Ira Weiny wrote: > > On Tue, Jun 23, 2020 at 04:51:31PM +0800, Xiao Yang wrote: > > > On 2020/6/19 23:15, Ira Weiny wrote: > > > > On Thu, Jun 18, 2020 at 11:35:56PM +0800, Xiao Yang wrote: > > > > > On 6/18/20 5:48 AM, Ira Weiny wrote: > > > > > > On Wed, Jun 17, 2020 at 05:32:04PM +0800, Xiao Yang wrote: > > > > > > > From: Xiao Yang > > [snip] > > > > > > > > } > > > > > > @@ -124,17 +151,11 @@ do_tests() > > > > > > # make xfs aligned for PMD fault testing > > > > > > _scratch_mkfs_geom $(_get_hugepagesize) 1>> $seqres.full 2>&1 > > > > > > -# mount with dax option > > > > > > -_scratch_mount "-o dax" > > > > > > - > > > Hi Ira, > > > > > > Why do you want to remove this combination(i.e. test per-inode DAX flag > > > under mounting with dax option) ? > > > Is it because mounting with dax option ignore FS_XFLAG_DAX flag? > > > I think it is a reasonable combination. :-) > > Yes running with the DAX mount option really does not test anything IMO. > Hi Ira, > > Sorry for the late reply because I was busy with other tasks last week. :-) > > After reading related code, setting/clearing FS_XFLAG_DAX have no chance to > change S_DAX > flag if mount with dax option, so I will remove this combination in v3 > patch. > > > > > > > tsize=$((128 * 1024 * 1024)) > > > > > > -do_tests > > > > > > -_scratch_unmount > > > > > > - > > > > > > # mount again without dax option > > > > > > export MOUNT_OPTIONS="" > > > > > > -_scratch_mount > > > > > > +_scratch_mount "-o dax=inode" > > > > > > do_tests > > > > > > # success, all done > > > Could we keep _scratch_mount without dax so that this test can run on both > > > old and new kernel? > > > See the following reasons: > > > 1) FS_XFLAG_DAX was introduced by commit 58f88ca("xfs: introduce per-inode > > > DAX enablement") since 2017. > > > 2) _scratch_mount with dax=inode is equal to _scratch_mount without dax. > > I suppose that would be ok. But being generic what happens when this runs on > > FS's which don't have the FS_XFLAG_DAX flag? is it ignored? > > Test will report notrun by _require_scratch_dax_iflag() If fs doesn't > support FS_XFLAG_DAX flag. > > > FWIW I believe that any FS (which includes older kernels) which do not support > > dax=inode have no need for this test to run. The use of FS_XFLAG_DAX on older > > xfs does not do anything and simply does not exist elsewhere. Only FS's which > > support dax=inode have behavior which needs to be tested IMO. > > I just want to test FS_XFLAG_DAX on older xfs by keeping _scratch_mount > without dax because > the original test(i.e. xfs/260) is designed to test this point. :-) Sure you can test swapping the flag itself but it really does nothing. > > BTW: It seems that older xfs can do dax mmap by setting/clearing > FS_XFLAG_DAX, or do I miss something? No it can only use DAX with '-o dax' mount option. Changing FS_XFLAG_DAX on xfs prior to 5.8 is effectively a no-op as the S_DAX flag would not be set. See "742d84290739 xfs: disable per-inode DAX flag" Ira > > Best Regards, > Xiao Yang > > Ira > > > > > Best Regards, > > > Xiao Yang > > > > . > > > > > > > > > . > > > > >