From: Zorro Lang <zlang@redhat.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/377: filter out xattrs that don't start with 'user.'
Date: Sun, 5 Jul 2020 19:41:13 +0800 [thread overview]
Message-ID: <20200705114113.GS1938@dhcp-12-102.nay.redhat.com> (raw)
In-Reply-To: <20200701175205.342650-1-jlayton@kernel.org>
On Wed, Jul 01, 2020 at 01:52:05PM -0400, Jeff Layton wrote:
> Most hosts that I've been testing on seem to display security.selinux in
> listxattr. 377.out doesn't account for that so it routinely fails for me
> in testing.
>
> When testing the output of listxattr in generic/377, filter out any xattr
> names that don't start with 'user.'. That should help ensure consistent
> output on SELinux-enabled hosts.
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
Yeah, I hit this error[1] too. This patch looks good to me.
One more question, do you hit similar failure on generic/062, likes [2]?
Thanks,
Zorro
[1]
--- /dev/fd/63 2020-07-02 12:07:42.948327419 -0400
+++ results/generic/377.out.bad 2020-07-02 12:07:41.990305624 -0400
@@ -1,4 +1,5 @@
QA output created by 377
+xattr: security.selinux
xattr: user.foo
xattr: user.hello
xattr: user.ping
...
[2]
--- /dev/fd/63 2020-07-02 07:15:09.072853920 -0400
+++ results/generic/062.out.bad 2020-07-02 07:15:08.156833194 -0400
@@ -52,6 +52,7 @@
SCRATCH_MNT/reg: user.name2: No such attribute or operation not permitted
*** final list (strings, type=reg, nsp=user)
# file: SCRATCH_MNT/reg
+security.selinux=0x73797374656d5f753a6f626a6563745f723a6e66735f743a733000
user.name=0xbabe
user.name3=0xdeface
...
> tests/generic/377 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> I'm not sure why this doesn't fail for most people, unless most are
> turning off SELinux. Is this the right approach?
>
> diff --git a/tests/generic/377 b/tests/generic/377
> index f7835ee8ff9e..f08abdca60a6 100755
> --- a/tests/generic/377
> +++ b/tests/generic/377
> @@ -48,7 +48,7 @@ $SETFATTR_PROG -n user.ping -v pong $testfile
> $SETFATTR_PROG -n user.hello -v there $testfile
>
> # 1. Call listxattr without buffer length argument. This should succeed.
> -$listxattr $testfile | sort
> +$listxattr $testfile | grep '^xattr: user\.' | sort
>
> # 2. Calling listxattr on nonexistant file should fail with -ENOENT.
> $listxattr ""
> @@ -66,7 +66,7 @@ $listxattr $testfile 9
> $listxattr $testfile 11
>
> # 6. Calling listxattr with buffersize bigger than needed should succeed.
> -$listxattr $testfile 500 | sort
> +$listxattr $testfile 500 | grep '^xattr: user\.' | sort
>
> status=0
> exit
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-07-05 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 17:52 [PATCH] generic/377: filter out xattrs that don't start with 'user.' Jeff Layton
2020-07-05 11:41 ` Zorro Lang [this message]
2020-07-06 13:50 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200705114113.GS1938@dhcp-12-102.nay.redhat.com \
--to=zlang@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jlayton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).