From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 192EBC433E1 for ; Thu, 9 Jul 2020 09:58:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02E7B2074B for ; Thu, 9 Jul 2020 09:58:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbgGIJ6A (ORCPT ); Thu, 9 Jul 2020 05:58:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:46604 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbgGIJ6A (ORCPT ); Thu, 9 Jul 2020 05:58:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 07FD9AC50; Thu, 9 Jul 2020 09:57:58 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 394811E12C5; Thu, 9 Jul 2020 11:57:58 +0200 (CEST) From: Jan Kara To: Cc: , Jan Kara Subject: [PATCH] generic/530: Require metadata journaling Date: Thu, 9 Jul 2020 11:57:53 +0200 Message-Id: <20200709095753.3514-1-jack@suse.cz> X-Mailer: git-send-email 2.16.4 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org Test generic/530 doesn't make sence without metadata journalling as in that case, there's no way to recover shutdown fs besides fsck. ext4 can be configured without a journal and it supports shutdown ioctl even in that mode which makes this test fail for that configuration. Add requirement for metadata journalling to this test so that it's properly skipped. Signed-off-by: Jan Kara --- tests/generic/530 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/generic/530 b/tests/generic/530 index cb874ace902b..153a045dca87 100755 --- a/tests/generic/530 +++ b/tests/generic/530 @@ -33,6 +33,7 @@ _supported_fs generic _supported_os Linux _require_scratch _require_scratch_shutdown +_require_metadata_journaling _require_test_program "t_open_tmpfiles" rm -f $seqres.full -- 2.16.4