From: Dave Chinner <david@fromorbit.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] check: add CLI option to repeat tests
Date: Mon, 13 Jul 2020 09:54:20 +1000 [thread overview]
Message-ID: <20200712235420.GI5369@dread.disaster.area> (raw)
In-Reply-To: <20200708081518.4oqe4menrpifbags@work>
On Wed, Jul 08, 2020 at 10:15:18AM +0200, Lukas Czerner wrote:
> On Wed, Jul 08, 2020 at 03:35:13PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Frequently when trying to reproduce a problem I want to run a set of
> > specific tests in a loop, over and over again. I run fstests from a
> > set of run scripts that have non-trivial overhead (e.g. patterning
> > block devices before the runs start), so if all I want to do is run
> > the same test 100x, using a shell loop over the entire run
> > scripts reduces the iteration rate substantially.
> >
> > Hence add an option to check to allow fstests to loop a number of
> > times over the configured test set without stopping.
>
> Hi Dave,
>
> this is useful as I am often doing the same. However what I am really
> missing is the ability to end the loop when a test fails and the ability
> to run tests in infinite loop (or until the test fails).
To run until a test set fails, I have just been using "-i 10000"
because if it passes 10000 loops, it isn't going to fail.. :)
Hence I didn't see a need to complicate things with a specific
"loop forever" options.
> It should be easy modification to make, what do you think ?
Feel free to add send a patch on top of this one to support that -
all of the failures I've been looking at with this have been "test
does not complete" failures, so it wasn't important to me.
As it is, right now I don't have time to feature creep simple
modifications like this into more complex functionality - I really
only sent this out because Willy mentioned on #xfs that he wished
there was a way to loop a test and I said "I've got a patch on my
local tree for that"....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2020-07-12 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 5:35 [PATCH] check: add CLI option to repeat tests Dave Chinner
2020-07-08 8:15 ` Lukas Czerner
2020-07-12 23:54 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712235420.GI5369@dread.disaster.area \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=lczerner@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).