FSTests Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] generic: assign a number of tests to attr group
@ 2020-07-13 12:26 Vladimir Zapolskiy
  2020-07-13 16:45 ` Darrick J. Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Zapolskiy @ 2020-07-13 12:26 UTC (permalink / raw)
  To: Eryu Guan; +Cc: fstests

A few generic tests have a _require_attrs runtime check for support
of extended file attributes by a tested filesystem, review shows that
the tests listed below are definitely using extended file attributes,
thus this implies that the tested filesystem should provide support of
the feature in general.

Adding the tests explicitly to attr group of tests allows to get a better
granularity of selecting or deselecting tests by groups in accordance to
extended file attributes feature given by a filesystem, the change affects
the next list of tests:

  * generic/037
  * generic/066
  * generic/103
  * generic/337
  * generic/449

Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
---
 tests/generic/group | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/generic/group b/tests/generic/group
index 3d7effe6d72a..a09c81a09abc 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -39,7 +39,7 @@
 034 auto quick metadata log
 035 auto quick
 036 auto aio rw stress
-037 metadata auto quick
+037 auto quick attr metadata
 038 auto stress
 039 metadata auto quick log
 040 metadata auto quick log
@@ -68,7 +68,7 @@
 063 auto quick prealloc punch insert
 064 auto quick prealloc collapse insert
 065 metadata auto quick log
-066 metadata auto quick log
+066 auto quick attr metadata log
 067 auto quick mount
 068 other auto freeze stress
 069 rw udf auto quick
@@ -105,7 +105,7 @@
 100 udf auto
 101 auto quick metadata log
 102 auto rw
-103 auto enospc quick
+103 auto quick attr enospc
 104 auto quick metadata log
 105 acl auto quick
 106 auto quick metadata log
@@ -339,7 +339,7 @@
 334 auto clone
 335 auto quick metadata log
 336 auto quick metadata log
-337 auto quick metadata
+337 auto quick attr metadata
 338 auto quick rw eio
 339 auto dir
 340 auto
@@ -451,7 +451,7 @@
 446 auto quick rw punch
 447 auto clone
 448 auto quick rw seek
-449 auto quick acl enospc
+449 auto quick acl attr enospc
 450 auto quick rw
 451 auto quick rw aio
 452 auto quick dax
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] generic: assign a number of tests to attr group
  2020-07-13 12:26 [PATCH] generic: assign a number of tests to attr group Vladimir Zapolskiy
@ 2020-07-13 16:45 ` Darrick J. Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2020-07-13 16:45 UTC (permalink / raw)
  To: Vladimir Zapolskiy; +Cc: Eryu Guan, fstests

On Mon, Jul 13, 2020 at 03:26:28PM +0300, Vladimir Zapolskiy wrote:
> A few generic tests have a _require_attrs runtime check for support
> of extended file attributes by a tested filesystem, review shows that
> the tests listed below are definitely using extended file attributes,
> thus this implies that the tested filesystem should provide support of
> the feature in general.
> 
> Adding the tests explicitly to attr group of tests allows to get a better
> granularity of selecting or deselecting tests by groups in accordance to
> extended file attributes feature given by a filesystem, the change affects
> the next list of tests:
> 
>   * generic/037
>   * generic/066
>   * generic/103
>   * generic/337
>   * generic/449

Aha! I had long suspected the attr group was missing a few tests...

> Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  tests/generic/group | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/generic/group b/tests/generic/group
> index 3d7effe6d72a..a09c81a09abc 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -39,7 +39,7 @@
>  034 auto quick metadata log
>  035 auto quick
>  036 auto aio rw stress
> -037 metadata auto quick
> +037 auto quick attr metadata
>  038 auto stress
>  039 metadata auto quick log
>  040 metadata auto quick log
> @@ -68,7 +68,7 @@
>  063 auto quick prealloc punch insert
>  064 auto quick prealloc collapse insert
>  065 metadata auto quick log
> -066 metadata auto quick log
> +066 auto quick attr metadata log
>  067 auto quick mount
>  068 other auto freeze stress
>  069 rw udf auto quick
> @@ -105,7 +105,7 @@
>  100 udf auto
>  101 auto quick metadata log
>  102 auto rw
> -103 auto enospc quick
> +103 auto quick attr enospc
>  104 auto quick metadata log
>  105 acl auto quick
>  106 auto quick metadata log
> @@ -339,7 +339,7 @@
>  334 auto clone
>  335 auto quick metadata log
>  336 auto quick metadata log
> -337 auto quick metadata
> +337 auto quick attr metadata
>  338 auto quick rw eio
>  339 auto dir
>  340 auto
> @@ -451,7 +451,7 @@
>  446 auto quick rw punch
>  447 auto clone
>  448 auto quick rw seek
> -449 auto quick acl enospc
> +449 auto quick acl attr enospc
>  450 auto quick rw
>  451 auto quick rw aio
>  452 auto quick dax
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-13 12:26 [PATCH] generic: assign a number of tests to attr group Vladimir Zapolskiy
2020-07-13 16:45 ` Darrick J. Wong

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git