FSTests Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] generic/079: remove assignment of the test to acl and attr groups
@ 2020-07-13 12:26 Vladimir Zapolskiy
  2020-07-13 16:46 ` Darrick J. Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Zapolskiy @ 2020-07-13 12:26 UTC (permalink / raw)
  To: Eryu Guan; +Cc: fstests

The test does not belong to acl group of tests, and expectedly the test
is supposed to pass on a filesystem which supports file attributes but
not ACLs.

In addition the test should be removed from attr group of tests, because
the attr group specifies tests which operate over extended file attributes,
this test does not fall into this category.

The change is intended to improve the assignment of tests to groups
to get better testing coverage, if a list of run tests is selected by
test group attributes.

Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
---
 tests/generic/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/group b/tests/generic/group
index d9ab9a31f2ed..3d7effe6d72a 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -81,7 +81,7 @@
 076 metadata rw udf auto quick stress
 077 acl attr auto enospc
 078 auto quick metadata
-079 acl attr ioctl metadata auto quick
+079 auto quick ioctl metadata
 080 auto quick
 081 auto quick
 082 auto quick quota
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] generic/079: remove assignment of the test to acl and attr groups
  2020-07-13 12:26 [PATCH] generic/079: remove assignment of the test to acl and attr groups Vladimir Zapolskiy
@ 2020-07-13 16:46 ` Darrick J. Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2020-07-13 16:46 UTC (permalink / raw)
  To: Vladimir Zapolskiy; +Cc: Eryu Guan, fstests

On Mon, Jul 13, 2020 at 03:26:48PM +0300, Vladimir Zapolskiy wrote:
> The test does not belong to acl group of tests, and expectedly the test
> is supposed to pass on a filesystem which supports file attributes but
> not ACLs.
> 
> In addition the test should be removed from attr group of tests, because
> the attr group specifies tests which operate over extended file attributes,
> this test does not fall into this category.
> 
> The change is intended to improve the assignment of tests to groups
> to get better testing coverage, if a list of run tests is selected by
> test group attributes.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  tests/generic/group | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/group b/tests/generic/group
> index d9ab9a31f2ed..3d7effe6d72a 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -81,7 +81,7 @@
>  076 metadata rw udf auto quick stress
>  077 acl attr auto enospc
>  078 auto quick metadata
> -079 acl attr ioctl metadata auto quick
> +079 auto quick ioctl metadata
>  080 auto quick
>  081 auto quick
>  082 auto quick quota
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-13 12:26 [PATCH] generic/079: remove assignment of the test to acl and attr groups Vladimir Zapolskiy
2020-07-13 16:46 ` Darrick J. Wong

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git