From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63915C433E3 for ; Tue, 14 Jul 2020 07:01:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36790221ED for ; Tue, 14 Jul 2020 07:01:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E6t6RT6q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725876AbgGNHBH (ORCPT ); Tue, 14 Jul 2020 03:01:07 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:22409 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725778AbgGNHBG (ORCPT ); Tue, 14 Jul 2020 03:01:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594710065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v0o6vS05dMQd9Z186F31LUjw5ChXs8ly1eNOlRWUGXc=; b=E6t6RT6qwRcvikuHhccEjpSkwgCipOVx66wbFRG20Cw9V7pG8AIE0xnVESMUbw4zlrHuNB Pm/Aly5PDtnglVtHa7sbu8fQyeEqLtrFqQ+3b0fKr0T7VAtLti+63LYuaJTREoLvGb8Awh GUBfTU8KlXdUfwab1Qlba07ds1l4jP4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-IOq-grENOSCtRE7efr8cHA-1; Tue, 14 Jul 2020 03:01:00 -0400 X-MC-Unique: IOq-grENOSCtRE7efr8cHA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 519241800D42; Tue, 14 Jul 2020 07:00:59 +0000 (UTC) Received: from localhost (dhcp-12-102.nay.redhat.com [10.66.12.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC1E2797EF; Tue, 14 Jul 2020 07:00:58 +0000 (UTC) Date: Tue, 14 Jul 2020 15:13:46 +0800 From: Zorro Lang To: "Darrick J. Wong" Cc: Eryu Guan , fstests@vger.kernel.org, xfs Subject: Re: [PATCH] xfs/010,030: filter AG header CRC error warnings Message-ID: <20200714071346.GY1938@dhcp-12-102.nay.redhat.com> Mail-Followup-To: "Darrick J. Wong" , Eryu Guan , fstests@vger.kernel.org, xfs References: <20200713184930.GK7600@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200713184930.GK7600@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Mon, Jul 13, 2020 at 11:49:30AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Filter out the new AG header CRC verification warnings in xfs_repair > since these tests were built before that existed. > > Signed-off-by: Darrick J. Wong > --- > tests/xfs/010 | 6 +++++- > tests/xfs/030 | 2 ++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/tests/xfs/010 b/tests/xfs/010 > index c341795d..ec23507a 100755 > --- a/tests/xfs/010 > +++ b/tests/xfs/010 > @@ -113,7 +113,11 @@ _check_scratch_fs > # nuke the finobt root, repair will have to regenerate from the inobt > _corrupt_finobt_root $SCRATCH_DEV > > -_scratch_xfs_repair 2>&1 | sed -e '/^bad finobt block/d' | _filter_repair_lostblocks I think this patch is based on another patch which hasn't been merged, right? Due to I can't find the *sed -e '/^bad finobt block/d'* on current xfstests-dev master branch, which HEAD is: aae8fbec generic/270: wait for fsstress processes to be killed Thanks, Zorro > +filter_finobt_repair() { > + sed -e '/^agi has bad CRC/d' -e '/^bad finobt block/d' | _filter_repair_lostblocks > +} > + > +_scratch_xfs_repair 2>&1 | filter_finobt_repair > > status=0 > exit > diff --git a/tests/xfs/030 b/tests/xfs/030 > index 8f95331a..a270e36c 100755 > --- a/tests/xfs/030 > +++ b/tests/xfs/030 > @@ -43,6 +43,8 @@ _check_ag() > -e '/^bad agbno AGBNO for rmapbt/d' \ > -e '/^bad agbno AGBNO for refcntbt/d' \ > -e '/^bad inobt block count/d' \ > + -e '/^agf has bad CRC/d' \ > + -e '/^agi has bad CRC/d' \ > -e '/^bad finobt block count/d' \ > -e '/^Missing reverse-mapping record.*/d' \ > -e '/^unknown block state, ag AGNO, block.*/d' >