* [PATCH] check: clear WARN_ONCE state before each test
@ 2020-07-15 11:42 Lukas Czerner
2020-07-17 6:22 ` Zorro Lang
2020-07-19 17:23 ` Eryu Guan
0 siblings, 2 replies; 3+ messages in thread
From: Lukas Czerner @ 2020-07-15 11:42 UTC (permalink / raw)
To: fstests
clear WARN_ONCE state before each test to allow a potential problem
to be reported for each test
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
check | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/check b/check
index 2e148e57..6ba64d5d 100755
--- a/check
+++ b/check
@@ -756,6 +756,11 @@ for section in $HOST_OPTIONS_SECTIONS; do
touch ${RESULT_DIR}/check_dmesg
fi
_try_wipe_scratch_devs > /dev/null 2>&1
+
+ # clear the WARN_ONCE state to allow a potential problem
+ # to be reported for each test
+ (echo 1 > /sys/kernel/debug/clear_warn_once) > /dev/null 2>&1
+
if [ "$DUMP_OUTPUT" = true ]; then
_run_seq 2>&1 | tee $tmp.out
# Because $? would get tee's return code
--
2.21.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] check: clear WARN_ONCE state before each test
2020-07-15 11:42 [PATCH] check: clear WARN_ONCE state before each test Lukas Czerner
@ 2020-07-17 6:22 ` Zorro Lang
2020-07-19 17:23 ` Eryu Guan
1 sibling, 0 replies; 3+ messages in thread
From: Zorro Lang @ 2020-07-17 6:22 UTC (permalink / raw)
To: Lukas Czerner; +Cc: fstests
On Wed, Jul 15, 2020 at 01:42:19PM +0200, Lukas Czerner wrote:
> clear WARN_ONCE state before each test to allow a potential problem
> to be reported for each test
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
> check | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/check b/check
> index 2e148e57..6ba64d5d 100755
> --- a/check
> +++ b/check
> @@ -756,6 +756,11 @@ for section in $HOST_OPTIONS_SECTIONS; do
> touch ${RESULT_DIR}/check_dmesg
> fi
> _try_wipe_scratch_devs > /dev/null 2>&1
> +
> + # clear the WARN_ONCE state to allow a potential problem
> + # to be reported for each test
> + (echo 1 > /sys/kernel/debug/clear_warn_once) > /dev/null 2>&1
Good to me.
Reviewed-by: Zorro Lang <zlang@redhat.com>
> +
> if [ "$DUMP_OUTPUT" = true ]; then
> _run_seq 2>&1 | tee $tmp.out
> # Because $? would get tee's return code
> --
> 2.21.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] check: clear WARN_ONCE state before each test
2020-07-15 11:42 [PATCH] check: clear WARN_ONCE state before each test Lukas Czerner
2020-07-17 6:22 ` Zorro Lang
@ 2020-07-19 17:23 ` Eryu Guan
1 sibling, 0 replies; 3+ messages in thread
From: Eryu Guan @ 2020-07-19 17:23 UTC (permalink / raw)
To: Lukas Czerner; +Cc: fstests
On Wed, Jul 15, 2020 at 01:42:19PM +0200, Lukas Czerner wrote:
> clear WARN_ONCE state before each test to allow a potential problem
> to be reported for each test
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
> check | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/check b/check
> index 2e148e57..6ba64d5d 100755
> --- a/check
> +++ b/check
> @@ -756,6 +756,11 @@ for section in $HOST_OPTIONS_SECTIONS; do
> touch ${RESULT_DIR}/check_dmesg
> fi
> _try_wipe_scratch_devs > /dev/null 2>&1
> +
> + # clear the WARN_ONCE state to allow a potential problem
> + # to be reported for each test
> + (echo 1 > /sys/kernel/debug/clear_warn_once) > /dev/null 2>&1
Thanks for the fix! I replaced "/sys/kernel/debug" with $DEBUGFS_MNT on commit.
Thanks,
Eryu
> +
> if [ "$DUMP_OUTPUT" = true ]; then
> _run_seq 2>&1 | tee $tmp.out
> # Because $? would get tee's return code
> --
> 2.21.3
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-19 17:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-15 11:42 [PATCH] check: clear WARN_ONCE state before each test Lukas Czerner
2020-07-17 6:22 ` Zorro Lang
2020-07-19 17:23 ` Eryu Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).