From: Zorro Lang <zlang@redhat.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] check: clear WARN_ONCE state before each test
Date: Fri, 17 Jul 2020 14:22:22 +0800 [thread overview]
Message-ID: <20200717062222.GC1938@dhcp-12-102.nay.redhat.com> (raw)
In-Reply-To: <20200715114219.18353-1-lczerner@redhat.com>
On Wed, Jul 15, 2020 at 01:42:19PM +0200, Lukas Czerner wrote:
> clear WARN_ONCE state before each test to allow a potential problem
> to be reported for each test
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
> check | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/check b/check
> index 2e148e57..6ba64d5d 100755
> --- a/check
> +++ b/check
> @@ -756,6 +756,11 @@ for section in $HOST_OPTIONS_SECTIONS; do
> touch ${RESULT_DIR}/check_dmesg
> fi
> _try_wipe_scratch_devs > /dev/null 2>&1
> +
> + # clear the WARN_ONCE state to allow a potential problem
> + # to be reported for each test
> + (echo 1 > /sys/kernel/debug/clear_warn_once) > /dev/null 2>&1
Good to me.
Reviewed-by: Zorro Lang <zlang@redhat.com>
> +
> if [ "$DUMP_OUTPUT" = true ]; then
> _run_seq 2>&1 | tee $tmp.out
> # Because $? would get tee's return code
> --
> 2.21.3
>
next prev parent reply other threads:[~2020-07-17 6:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 11:42 [PATCH] check: clear WARN_ONCE state before each test Lukas Czerner
2020-07-17 6:22 ` Zorro Lang [this message]
2020-07-19 17:23 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717062222.GC1938@dhcp-12-102.nay.redhat.com \
--to=zlang@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=lczerner@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).